Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T32405

[EPIC] MobileFrontend extension should stop special-casing main page
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
• MZMcBride
Aug 16 2011, 7:28 PM
Tags
Referenced Files
F31855111: Screen Shot 2020-06-05 at 8.27.58 AM.png
Jun 5 2020, 3:31 PM
F31855105: Screen Shot 2020-06-05 at 8.24.15 AM.png
Jun 5 2020, 3:31 PM
F31832264: mlwikipedia.jpeg
May 18 2020, 10:31 PM
F31812894: viwikipedia.jpeg
May 11 2020, 6:23 PM
F31812896: enwikipedia.jpeg
May 11 2020, 6:23 PM
F31808261: itwikipedia.jpeg
May 8 2020, 5:47 PM
F31808263: scowikipedia.jpeg
May 8 2020, 5:47 PM
F31803710: Screen Shot 2020-05-05 at 11.16.24 AM.png
May 5 2020, 6:17 PM
View All 30 Files
Subscribers
Acagastya
AfroThundr3007730
Aklapper
BrandonXLF
Florian
gerritbot
Izno
View All 30 Subscribers
Tokens
"Mountain of Wealth" token, awarded by Nemo_bis."Like" token, awarded by xSavitar.

Description

The MobileFrontend extension shouldn't special-case the main page. Currently a lot of the logic and infrastructure is based on a { if isMainPage() } { else ... } model, which is silly and unnecessary. The extension code should be flexible and adaptable to any page. A few tweaks might be necessary for the main page, but there doesn't need to be a completely different system in place for it.

Steps to achieve this

  • Audit all wiki pages which use special cased main pages
  • We should set $wgMFSpecialCaseMainPage = false for any projects currently not using mobile main page special casing
  • Deploy TemplateStyles to render this code obsolete
  • Community engagement - T138622 and T246401. All mobile main pages need to be updated to not use the mf- prefix using only the nomobile where necessary. See wikidata.org and English Wikipedia for examples.
  • Main page special casing turned off for all projects with $wgMFSpecialCaseMainPage
  • Remove special casing code from MobileFrontend (T257953)
  1. Sign off steps
  2. Addzip file of all projects before and after (@Jdlrobson has this)

Screenshots before and after for projects are listed here:
https://drive.google.com/drive/folders/1n4xB7Tk1klEnlw1EN-bSOReRQf791Jc-?usp=sharing

Details

Reference
bz30405
SubjectRepoBranchLines +/-
Drop main page special casing on all projectsoperations/mediawiki-configmaster+0 -369
Drop simplewiki mainpage special casingoperations/mediawiki-configmaster+0 -3
Stop special casing the main page on several projectsoperations/mediawiki-configmaster+0 -140
Stop special casing the main page on mobile for twelve wikisoperations/mediawiki-configmaster+0 -36
Drop enwiki mainpage special casingoperations/mediawiki-configmaster+0 -3
Legacy transforms can be disabled using mfnolegacytransform query stringmediawiki/extensions/MobileFrontendmaster+24 -1
Discourage use of MFSpecialCaseMainPage on edit preview to main pagemediawiki/extensions/MobileFrontendmaster+28 -3
Drop legacy main page special casing on select projectsoperations/mediawiki-configmaster+180 -234
Default wgMFSpecialCaseMainPage to falsemediawiki/extensions/MobileFrontendmaster+7 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
 ResolvedJdlrobsonT186627 Remove the MobileView API
 DeclinedNoneT173379 Remove mobileview API call for main page
 DuplicateNoneT172525 [EPIC] Deprecate MobileView API in MobileFrontend
 ResolvedJdlrobsonT32405 [EPIC] MobileFrontend extension should stop special-casing main page
 ResolvedJdlrobsonT138425 wgMFSpecialCaseMainPage should be disabled on new wiki installs
 DuplicateNoneT138449 Throw warning when edits made to a main page which uses special casing
 DuplicateNoneT138622 Help community migrate away from legacy Main page special casing
 ResolvedTgrT133410 Deploy TemplateStyles to WMF production
 ResolvedAnomieT133414 Deploy TemplateStyles to the beta-cluster
 ResolvedtstarlingT133408 Security review of TemplateStyles
 ResolvedcorenT133409 Complete initial version of TemplateStyles sufficient to do security review and then deploy it to WMF production
 ResolvedAnomieT135788 TemplateStyles should support media queries
 DeclinedBUG REPORTNoneT138343 [BUG] Certain Articles can Scroll Left & Right
 ResolvedAnomieT136054 TemplateStyles puts css in page_props table, which might be subject to race conditions, etc
 ResolvedEsandersT164790 Add class mw-parser-output to VE's editing area
 ResolvedEsandersT164791 Add class mw-parser-output to Flow comment- or content- containing elements
 ResolvedssastryT164792 Add class mw-parser-output to Parsoid's output
 ResolvedAnomieT167349 Tidy on WMF sites removes `<style>` tags
 ResolvedCKoerner_WMFT170863 Identify and coordinate deployment of initial deployment of Template Styles with select non-content Wikis
 ResolvedjhsobyT176082 Deploy TemplateStyles to svwiki
 ResolvedTgrT176268 Feature flag ("kill switch") for TemplateStyles
 DeclinedTgrT176269 Disallow <templatestyles> tags in non-Template namespaces
 ResolvedcorenT483 RfC: Allow styling in templates
 ResolvedAnomieT989 CSS validator survey and design work
 ResolvedTgrT188198 Enable TemplateStyles on ruwiki on 2018-04-10
 DeclinedNoneT187141 Deduplicate template styles in mobileviews API
 ResolvedssastryT187142 Deduplicate template styles in Parsoid
 ResolvedTgrT189022 Deploy TemplateStyles to zhwiki on 2018-07-19
 ResolvedTgrT190910 Create and deploy configuration change to enable TemplateStyles on German Wikipedia on 2018-04-04
 ResolvedTgrT191612 Make the creation of CSS pages with TemplateStyles work more sensibly on the German Wikipedia
 Resolved• DeskanaT189834 [Epic] Deploy TemplateStyles to Wikivoyages
 ResolvedCKoerner_WMFT189835 Write announcement for TemplateStyles deployment to Wikivoyages
 Resolved• Whatamidoing-WMFT189836 Set deployment date for TemplateStyles on Wikivoyages, and publish announcement
 ResolvedTgrT189838 Create and deploy configuration change to enable TemplateStyles on Wikivoyages on 2018-03-28
 ResolvedTgrT191452 Deploy TemplateStyles on French Wikipedia on 2018-07-19
 ResolvedTgrT193786 [task] Configure TemplateStyles for nowiki
 ResolvedUrbanecmT197526 TemplateStyles in the Russian Wikiquote
 ResolvedTgrT197603 Deploy TemplateStyles to the English Wikipedia on 2018-07-19
 ResolvedTacsipacsiT198725 Deploy TemplateStyles on huwiktionary
 ResolvedTgrT199909 Deploy TemplateStyles everywhere on 2018-08-09
 ResolvedCKoerner_WMFT199982 Announce that TemplateStyles is being deployed everywhere with mass messages
 ResolvedJdlrobsonT195813 Hindi MainPage should use Template Styles (migrate all MediaWiki:Mobile.css and MediaWiki:MobileMainPage.css styles to templates)
 DeclinedNoneT203967 TemplateStyles should allow for "mobile-only" styles
 DeclinedNoneT198963 Add "Did you know..." and "On this day" sections from desktop main page to mobile main page
 OpenNoneT200880 Editor should flag mobile editing warnings
 ResolvedAmmarpadT241888 Disabling MFSpecialCaseMainPage on French Wiktionary
 ResolvedJdlrobsonT246401 Editors must review their main pages: End of life for wgMFSpecialCaseMainPage
 ResolvedKizuleT252065 Turn off main page special casing on itwiki
 ResolvedKizuleT252048 Disable $wgMFSpecialCaseMainPage for Scots Wikipedia
 DuplicateBrandonXLFT253268 Disable $wgMFSpecialCaseMainPage for English Wikipedia
 ResolvedJdlrobsonT254287 Final warning: Mobile main page special casing will be disabled July
ResolvedAmmarpadT254731 Turn off main page special casing on itwikisource and vecwikisource
 ResolvedJdlrobsonT257953 [Technical debt payoff] Drop MFSpecialCaseMainPage, from MobileFrontend

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Kenrick95 subscribed.Mar 10 2020, 5:52 AM
Jdlrobson updated the task description. (Show Details)Mar 10 2020, 11:28 PM
Krinkle edited projects, added Performance-Team (Radar); removed MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Mar 24 2020, 8:34 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle removed a subscriber: • wikibugs-l-list.
Jdlrobson mentioned this in T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.Mar 24 2020, 8:53 PM
gerritbot added a comment.Apr 2 2020, 4:52 PM

Change 569174 abandoned by Jdlrobson:
Discourage use of MFSpecialCaseMainPage on edit preview to main page

Reason:
I need to discuss this with Alex. Might not be the best solution here.

https://gerrit.wikimedia.org/r/569174

Jdlrobson updated the task description. (Show Details)Apr 10 2020, 7:10 PM
Jdlrobson updated the task description. (Show Details)Apr 10 2020, 7:17 PM
Jdlrobson updated the task description. (Show Details)Apr 10 2020, 8:23 PM
xSavitar awarded a token.Apr 17 2020, 7:35 PM
xSavitar subscribed.
Jdlrobson added a subtask: T246401: Editors must review their main pages: End of life for wgMFSpecialCaseMainPage.May 5 2020, 6:00 PM
Jdlrobson updated the task description. (Show Details)May 5 2020, 6:17 PM
Sakretsu added a subtask: T252065: Turn off main page special casing on itwiki.May 6 2020, 8:06 PM
Kizule added a subtask: T252048: Disable $wgMFSpecialCaseMainPage for Scots Wikipedia.May 6 2020, 8:07 PM
Jdlrobson updated the task description. (Show Details)May 8 2020, 5:47 PM
Jdlrobson mentioned this in T252048: Disable $wgMFSpecialCaseMainPage for Scots Wikipedia.
Jdlrobson updated the task description. (Show Details)May 11 2020, 6:23 PM
Jdlrobson updated the task description. (Show Details)May 11 2020, 6:26 PM
Kizule closed subtask T252065: Turn off main page special casing on itwiki as Resolved.May 11 2020, 6:37 PM
Kizule closed subtask T252048: Disable $wgMFSpecialCaseMainPage for Scots Wikipedia as Resolved.
Jdlrobson updated the task description. (Show Details)May 18 2020, 10:31 PM
BrandonXLF added a subtask: T253268: Disable $wgMFSpecialCaseMainPage for English Wikipedia.May 20 2020, 10:56 PM
BrandonXLF merged a task: T253268: Disable $wgMFSpecialCaseMainPage for English Wikipedia.May 21 2020, 8:48 AM
BrandonXLF subscribed.
gerritbot added a comment.May 26 2020, 2:59 PM

Change 570180 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop enwiki mainpage special casing

https://gerrit.wikimedia.org/r/570180

Stashbot added a comment.May 26 2020, 3:01 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-26T15:01:40Z] <jforrester@deploy1001> Synchronized dblists/mobilemainpagelegacy.dblist: Drop enwiki mobile mainpage special casing T32405 (duration: 00m 59s)

Jdlrobson updated the task description. (Show Details)May 27 2020, 2:18 AM
gerritbot added a comment.May 27 2020, 5:18 PM

Change 599085 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Stop special casing the main page

https://gerrit.wikimedia.org/r/599085

gerritbot added a project: Patch-For-Review.May 27 2020, 5:18 PM
gerritbot added a comment.May 27 2020, 7:07 PM

Change 599085 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop special casing the main page on mobile for twelve wikis

https://gerrit.wikimedia.org/r/599085

Stashbot added a comment.May 27 2020, 7:09 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-27T19:09:24Z] <jforrester@deploy1001> Synchronized dblists/mobilemainpagelegacy.dblist: T32405 Stop special casing the main page on mobile for twelve wikis (duration: 01m 05s)

Jdforrester-WMF subscribed.May 27 2020, 7:10 PM

Now down to 168 wikis still in legacy mode.

Jdlrobson updated the task description. (Show Details)May 27 2020, 7:10 PM
Volker_E unsubscribed.May 27 2020, 7:11 PM
Maintenance_bot removed a project: Patch-For-Review.May 27 2020, 7:11 PM
Jdlrobson updated the task description. (Show Details)May 27 2020, 8:38 PM
Jdlrobson closed subtask T246401: Editors must review their main pages: End of life for wgMFSpecialCaseMainPage as Resolved.May 28 2020, 1:44 AM
PatsagornY subscribed.May 29 2020, 7:51 AM
gerritbot added a comment.Jun 2 2020, 8:16 PM

Change 601847 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Stop special casing the main page on several projects

https://gerrit.wikimedia.org/r/601847

gerritbot added a project: Patch-For-Review.Jun 2 2020, 8:16 PM
Jdlrobson added a project: MW-1.35-release.Jun 2 2020, 9:38 PM
Jdlrobson updated the task description. (Show Details)Jun 2 2020, 10:27 PM
MarkAHershberger unsubscribed.Jun 3 2020, 12:10 AM
Acagastya subscribed.Jun 3 2020, 6:23 AM

Can anyone please share a before-and-after photos of what has changed? Thank you.

Jdlrobson added a comment.Jun 3 2020, 4:05 PM

@Acagastya for which project? I've been collecting before and after photos in this task above. I have a few more to add later today.

gerritbot added a comment.Jun 3 2020, 7:03 PM

Change 601847 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop special casing the main page on several projects

https://gerrit.wikimedia.org/r/601847

Stashbot added a comment.Jun 3 2020, 7:05 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-03T19:05:44Z] <jforrester@deploy1001> Synchronized dblists/mobilemainpagelegacy.dblist: T32405 Stop special casing the main page on another 47 projects (duration: 01m 08s)

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2020, 7:10 PM
Jdlrobson updated the task description. (Show Details)Jun 3 2020, 9:17 PM
Acagastya added a comment.Jun 5 2020, 8:43 AM

@Jdlrobson I was asking for en.wikinews.

Jdlrobson added a comment.Jun 5 2020, 3:31 PM

@Acagastya prior to the change it looked like this:

Screen Shot 2020-06-05 at 8.24.15 AM.png (1×666 px, 204 KB)

It now displays all content but note the headings provided by MobileFrontend are no longer displaying:

Screen Shot 2020-06-05 at 8.27.58 AM.png (1×618 px, 255 KB)

I would advise l_title rules from https://en.m.wikinews.org/wiki/MediaWiki:Common.css to a TemplateStyle or https://en.m.wikinews.org/wiki/Template:Main_Page/minerva.css

You can add the nomobile class to box with RSS elements if you want to hide those like before.

Acagastya added a comment.Jun 6 2020, 11:25 AM

Thank you @Jdlrobson. I will have a look.

Sakretsu added a subtask: T254731: Turn off main page special casing on itwikisource and vecwikisource.Jun 8 2020, 9:58 AM
Nemo_bis awarded a token.Jun 8 2020, 10:03 AM
Nemo_bis subscribed.Jun 8 2020, 10:05 AM
In T32405#6196782, @Jdlrobson wrote:

It now displays all content but note the headings provided by MobileFrontend are no longer displaying:

Nice, looks much better now that it's not mutilated!

Jdlrobson added a project: User-Jdlrobson.Jun 9 2020, 11:50 PM
Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.
gerritbot added a comment.Jun 12 2020, 1:22 AM

Change 604973 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[operations/mediawiki-config@master] Drop simplewiki mainpage special casing

https://gerrit.wikimedia.org/r/604973

gerritbot added a project: Patch-For-Review.Jun 12 2020, 1:22 AM
gerritbot added a comment.Jun 16 2020, 11:16 AM

Change 604973 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop simplewiki mainpage special casing

https://gerrit.wikimedia.org/r/604973

Stashbot added a comment.Jun 16 2020, 11:18 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-16T11:18:43Z] <jforrester@deploy1001> Synchronized dblists/mobilemainpagelegacy.dblist: T32405 T254731 Drop mobile special casing of main page for simplewiki, itwikisource, vecwikisource (duration: 01m 05s)

Stashbot mentioned this in T254731: Turn off main page special casing on itwikisource and vecwikisource.Jun 16 2020, 11:18 AM
Jdforrester-WMF closed subtask T254731: Turn off main page special casing on itwikisource and vecwikisource as Resolved.Jun 16 2020, 11:25 AM
Jdlrobson claimed this task.Jul 11 2020, 12:10 AM
Jdlrobson edited projects, added MW-1.36-release; removed MW-1.35-release.

I plan to remove this code as soon as the branch is cut. So technically while supporting is being dropped in 1.35 the actual code will be removed in 1.36

gerritbot added a comment.Jul 13 2020, 9:26 PM

Change 612423 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Drop main page special casing on all projects

https://gerrit.wikimedia.org/r/612423

Jdlrobson updated the task description. (Show Details)Jul 13 2020, 9:26 PM
gerritbot added a comment.Jul 14 2020, 6:02 PM

Change 612423 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop main page special casing on all projects

https://gerrit.wikimedia.org/r/612423

Stashbot mentioned this in T254287: Final warning: Mobile main page special casing will be disabled July .Jul 14 2020, 6:05 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-14T18:05:44Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T32405 T254287 Stop varying wgMFSpecialCaseMainPage (duration: 01m 05s)

Stashbot added a comment.Jul 14 2020, 6:07 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-14T18:07:31Z] <jforrester@deploy1001> Synchronized multiversion/MWConfigCacheGenerator.php: T32405 T254287 Stop loading the mobilemainpagelegacy dblist (duration: 01m 05s)

Stashbot added a comment.Jul 14 2020, 6:09 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-14T18:09:36Z] <jforrester@deploy1001> Synchronized dblists/: T32405 T254287 Remove the mobilemainpagelegacy dblist (duration: 01m 04s)

Jdforrester-WMF added a comment.Jul 14 2020, 6:10 PM

This is now deployed.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog (Tracking).Jul 14 2020, 6:36 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T257953: [Technical debt payoff] Drop MFSpecialCaseMainPage, from MobileFrontend.Jul 14 2020, 6:50 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Kanbanana-FY-2020-21).
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Epics to Team: web on the MobileFrontend board.Jul 24 2020, 2:29 AM
Jdlrobson closed subtask T254287: Final warning: Mobile main page special casing will be disabled July as Resolved.Jul 30 2020, 3:15 PM
xSavitar added a comment.Aug 18 2020, 9:37 PM

@Jdlrobson, per T259970, it seems we got it covered here and you're on it?

xSavitar mentioned this in T259970: Wrap-up removal of PHP deprecations from MobileFrontend.Aug 18 2020, 9:38 PM
Jdlrobson added a comment.Aug 18 2020, 10:16 PM

Patch is not quite ready and I will likely need some review but yeh I can focus on this soonish (maybe next week)

Jdlrobson closed this task as Resolved.Aug 19 2020, 4:56 PM
Jdlrobson updated the task description. (Show Details)

🎉🎉🎉🎉🎉🎉🎉🎉

Jdlrobson closed subtask T257953: [Technical debt payoff] Drop MFSpecialCaseMainPage, from MobileFrontend as Resolved.Aug 19 2020, 4:56 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog (Tracking).Aug 26 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits