Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

[AMC] fix alignment of "Edit your list of watched pages" button on AMC watchlist page
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

The Edit your list of watched pages should be aligned with the main content on the page (left-aligned for LTR languages and right-aligned for RTL languages).

Screen Shot 2019-10-15 at 12.25.19 PM.png (843×565 px, 132 KB)

currentupdated
en.m.wikipedia.beta.wmflabs.org_wiki_Special_Watchlist_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&enhanced=1&urlversion=2(iPhone 6_7_8).png (1×750 px, 136 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_Special_Watchlist_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&urlversion=2(iPhone 6_7_8).png (1×750 px, 152 KB)

Developer notes

The core style resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.WatchlistTopSectionWidget.less should be restricted to a tablet media query.

acceptance criteria

  • the design should be mobile first
  • Should require no changes to Minerva.

QA Results

ACStatusDetails
1T235535#5623940

Event Timeline

alexhollender_WMF renamed this task from [AMC] fix alignment of "Edit your list of watched pages" on AMC watchlist page to [AMC] fix alignment of "Edit your list of watched pages" button on AMC watchlist page.Oct 15 2019, 4:28 PM
ovasileva triaged this task as Medium priority.Oct 15 2019, 5:01 PM

Change 545626 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Saved filters button should be responsive

https://gerrit.wikimedia.org/r/545626

Change 545626 merged by jenkins-bot:
[mediawiki/core@master] Saved filters button should be responsive

https://gerrit.wikimedia.org/r/545626

Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

The Edit your list of watched pages should be aligned with the main content on the page (left-aligned for LTR languages and right-aligned for RTL languages).

T235536.png (2×1 px, 286 KB)

T235536RTL.png (2×1 px, 246 KB)