Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T225127

Display core version of watchlist page for AMC users
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Jun 5 2019, 5:35 PM
Tags
Referenced Files
F30795585: T225127.png
Oct 17 2019, 2:57 AM
F30543850: en.m.wikipedia.beta.wmflabs.org_wiki_Special_Watchlist_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&enhanced=1&urlversion=2(iPhone 6_7_8).png
Oct 4 2019, 4:45 PM
F30543849: en.m.wikipedia.beta.wmflabs.org_wiki_Special_Watchlist_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&enhanced=1&urlversion=2(iPhone 6_7_8) (1).png
Oct 4 2019, 4:45 PM
F30478536: Screenshot 2019-09-26 at 5.23.12 PM.png
Sep 27 2019, 12:25 AM
F30478550: Screenshot 2019-09-26 at 5.23.48 PM.png
Sep 27 2019, 12:25 AM
F30478524: watchlist1.gif
Sep 27 2019, 12:25 AM
F30478530: Screenshot 2019-09-26 at 5.22.50 PM.png
Sep 27 2019, 12:25 AM
F30453642: Screen Shot 2019-09-24 at 11.11.47.png
Sep 24 2019, 9:12 AM
View All 14 Files
Subscribers
Aklapper
• alexhollender_WMF
Edtadros
Jdlrobson
Jdrewniak
Masumrezarock100
ovasileva
Tokens
"Orange Medal" token, awarded by Krinkle."Like" token, awarded by Masumrezarock100.

Description

User story

As an experienced editor, I would like to be able to access the entire functionality of the watchlist page from my mobile device so that I can perform my work on mobile

Acceptance criteria

  • all desktop functionality (with tentative exceptions TBD) will be available on mobile - this means we need to disable the redirects for 2 pages - EditWatchlist and Watchlist (see T225127#5446716 assume solution A)
  • use a feature flag to allow us to QA and design review before shipping. Copy the example of wgMFUseDesktopSpecialHistoryPage - and create wgMFUseDesktopSpecialWatchlistPage
  • Make sure styles for Contributions and RecentChanges are used on Watchlist using existing menus. Any new things are out of scope and will be split out into a new task. Don't touch the mixins!
  • Do not touch JS mentioned in problem2 on T225127#5446716. That if a problem will be descoped.

Design notes

The Watchlist page seems to be quite similar to recent changes in terms of appearance and functionality. It contains the same filter component at the top, and a similar list of pages below. Here is a basic design following from the work in T223922:

Basic DesignRefinements
image.png (1×395 px, 152 KB)
image.png (1×395 px, 159 KB)

Notes

let's try to use as much of the work we did on recent changes here as well, as filters and list items are extremely similar

QA Steps

  1. visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist
  2. play around on the page
  3. design of page should match the "Basic design" above, minus the issues called out in T235535 and T235536

Sign off steps

  • Open a task for enabling the Watchlist in production.

QA Results

ACStatusDetails
1✅T225127#5582793

Details

SubjectRepoBranchLines +/-
Avoid flash of unstyled content on Special:Watchlistmediawiki/skins/MinervaNeuemaster+12 -6
Improve the top section of Special:Watchlist for small screensmediawiki/coremaster+28 -0
beta: enable desktop watchlist for mobile AMC usersoperations/mediawiki-configmaster+7 -0
beta: enable desktop watchlist for mobile AMC usersoperations/mediawiki-configmaster+7 -0
Provide feature for exposing desktop Special:Watchlist pagemediawiki/extensions/MobileFrontendmaster+16 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedGoalovasilevaT198313 [GOAL] Advanced mobile contributions
 ResolvedovasilevaT228916 Deploy AMC to all Wikipedias
 ResolvedovasilevaT223922 [EPIC] Display core version of recent changes page for AMC users
 DuplicateNoneT178194 Enable new RC on mobile
 ResolvedJdlrobsonT197065 New Filters for Edit Review: UI displays poorly when the window is narrow
 ResolvedovasilevaT214531 History links with curid set do not redirect properly on mobile
 ResolvedJdlrobsonT223230 Enable Recent Changes modules on mobile
 DuplicateNoneT223231 mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile
 ResolvedNoneT223363 Cleanup Special:RecentChanges filters appearance on Minerva (mobile)
 ResolvedovasilevaT224216 Add recent changes link into main menu for AMC
 ResolvedMNeislerT223206 [Hackday] Analyse user interactions with RecentChanges
 ResolvedSpikeJdrewniakT224432 [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode
 ResolvedJdrewniakT224655 [SPIKE] Allow recent changes to display filters in AMC mode
 ResolvedovasilevaT225499 Fix Special:RecentChanges dropdown widget on mobile
 ResolvedNoneT229360 [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience
 ResolvedovasilevaT235414 Deploy core version of watchlist for AMC users
 ResolvedovasilevaT225127 Display core version of watchlist page for AMC users
 InvalidNoneT235534 [AMC] fix alignment of "Edit your list of watched pages
 ResolvedovasilevaT235535 [AMC] fix alignment of "Edit your list of watched pages" button on AMC watchlist page
 ResolvedovasilevaT235536 [AMC] fix alignment of "Saved filters" button on AMC watchlist page
 ResolvedphuedxT214540 [EPIC] AMC Navigation - user menu
 Resolved• NiedzielskiT224070 Update notifications & search icons (AMC & non-AMC)
 ResolvedBUG REPORTovasilevaT229228 Watch/unwatch url is incorrect for non-js users
 DeclinedBUG REPORTJdlrobsonT229716 [BUG] Watchlist link feed/list preference not honoured when following user Menu watchlist link.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Masumrezarock100 subscribed.Sep 7 2019, 10:27 AM
Jdlrobson reassigned this task from Jdrewniak to ovasileva.Sep 10 2019, 3:42 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdrewniak.
Jdlrobson added a comment.Sep 10 2019, 3:44 PM

I think this is ready @ovasileva provided we are okay with the scope - get these enabled behind a feature flag doing the minimum possible.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 10 2019, 3:44 PM
Jdlrobson updated the task description. (Show Details)Sep 10 2019, 4:19 PM
Jdlrobson updated the task description. (Show Details)
ovasileva removed ovasileva as the assignee of this task.Sep 10 2019, 4:20 PM
ovasileva set the point value for this task to 3.
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jdrewniak claimed this task.Sep 16 2019, 11:49 AM
Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Masumrezarock100 updated the task description. (Show Details)Sep 16 2019, 12:05 PM
gerritbot added a comment.Sep 16 2019, 12:52 PM

Change 537104 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Provide feature for exposing desktop Special:Watchlist page

https://gerrit.wikimedia.org/r/537104

gerritbot added a project: Patch-For-Review.Sep 16 2019, 12:52 PM
gerritbot added a comment.Sep 16 2019, 6:34 PM

Change 537104 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Provide feature for exposing desktop Special:Watchlist page

https://gerrit.wikimedia.org/r/537104

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 16 2019, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2019, 7:10 PM
gerritbot added a comment.Sep 17 2019, 5:24 PM

Change 537492 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[operations/mediawiki-config@master] beta: enable desktop watchlist for mobile AMC users

https://gerrit.wikimedia.org/r/537492

gerritbot added a project: Patch-For-Review.Sep 17 2019, 5:24 PM
gerritbot added a comment.Sep 17 2019, 5:27 PM

Change 537492 abandoned by Jdrewniak:
beta: enable desktop watchlist for mobile AMC users

https://gerrit.wikimedia.org/r/537492

gerritbot added a comment.Sep 17 2019, 5:32 PM

Change 537495 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[operations/mediawiki-config@master] beta: enable desktop watchlist for mobile AMC users

https://gerrit.wikimedia.org/r/537495

gerritbot added a comment.Sep 17 2019, 7:19 PM

Change 537495 merged by jenkins-bot:
[operations/mediawiki-config@master] beta: enable desktop watchlist for mobile AMC users

https://gerrit.wikimedia.org/r/537495

Masumrezarock100 awarded a token.Sep 17 2019, 7:51 PM

So the change has been merged. Where I can see the demo?

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2019, 8:11 PM
MBinder_WMF unsubscribed.Sep 17 2019, 10:40 PM
Jdrewniak moved this task from Doing to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 18 2019, 8:36 AM

We've tried enabling this change on the beta cluster, but for unknown reasons it doesn't appear to work there (works locally :/). This requires further investigation, the fault might be with the beta cluster or with the change itself.

Jdrewniak added a comment.Sep 24 2019, 9:12 AM

There's a minor style issue with the top portion of the page where the description and "edit your list of watched pages" button is.

Screen Shot 2019-09-24 at 11.11.47.png (1×762 px, 292 KB)

Fix arriving shortly.

gerritbot added a comment.Sep 24 2019, 9:27 AM

Change 538847 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/core@master] Improve the top section of Special:Watchlist for small screens

https://gerrit.wikimedia.org/r/538847

gerritbot added a project: Patch-For-Review.Sep 24 2019, 9:27 AM
Jdrewniak removed Jdrewniak as the assignee of this task.Sep 24 2019, 9:29 AM
Jdrewniak moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
gerritbot added a comment.Sep 24 2019, 9:19 PM

Change 538847 merged by jenkins-bot:
[mediawiki/core@master] Improve the top section of Special:Watchlist for small screens

https://gerrit.wikimedia.org/r/538847

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.25; 2019-10-01); removed MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 24 2019, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 10:10 PM
Jdlrobson assigned this task to • alexhollender_WMF.Sep 24 2019, 11:34 PM
Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jdlrobson updated the task description. (Show Details)

@Jdrewniak I'm seeing the font-size change as the page loads...

Krinkle awarded a token.Sep 25 2019, 4:19 AM
Jdrewniak added a comment.Sep 25 2019, 5:18 PM

@Jdlrobson that seems fixable, will do!

Jdrewniak claimed this task.Sep 25 2019, 5:19 PM
Jdrewniak moved this task from Needs Design Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jdlrobson mentioned this in T233845: Non-AMC Mobile watchlist shows opaque names for Structured Discussion topics.Sep 25 2019, 9:07 PM
gerritbot added a comment.Sep 26 2019, 7:34 PM

Change 539403 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Avoid flash of unstyled content on Special:Watchlist

https://gerrit.wikimedia.org/r/539403

gerritbot added a project: Patch-For-Review.Sep 26 2019, 7:34 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 26 2019, 7:34 PM
gerritbot added a comment.Sep 26 2019, 11:03 PM

Change 539403 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Avoid flash of unstyled content on Special:Watchlist

https://gerrit.wikimedia.org/r/539403

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2019, 11:10 PM
Jdlrobson reassigned this task from Jdrewniak to • alexhollender_WMF.Sep 27 2019, 12:20 AM
Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jdlrobson updated the task description. (Show Details)Sep 27 2019, 12:24 AM

One more FOUC:

watchlist1.gif (420×387 px, 86 KB)

Issue 2:

Screenshot 2019-09-26 at 5.22.50 PM.png (160×400 px, 17 KB)

Issue 3 Text too big?

Screenshot 2019-09-26 at 5.23.12 PM.png (228×381 px, 33 KB)

Issue 4:
LARGE BUTTON!
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist/clear

Screenshot 2019-09-26 at 5.23.48 PM.png (458×411 px, 47 KB)

Issue 5:
T232284

Per the last acceptance criteria, we should probably capture these and any others in separate bugs...? What do you think?

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).Sep 30 2019, 5:19 PM
MBinder_WMF moved this task from Needs Analysis to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Sep 30 2019, 5:25 PM
• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Oct 4 2019, 4:45 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

Looking good. Could we left-align the Edit your list of watched pages and Saved filters buttons? The Saved filters button also needs some padding/margin on top.

currentupdated
en.m.wikipedia.beta.wmflabs.org_wiki_Special_Watchlist_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&enhanced=1&urlversion=2(iPhone 6_7_8).png (1×750 px, 136 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_Special_Watchlist_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&enhanced=1&urlversion=2(iPhone 6_7_8) (1).png (1×750 px, 133 KB)
Jdlrobson updated the task description. (Show Details)Oct 4 2019, 5:28 PM
Jdlrobson moved this task from Needs More Work to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 7 2019, 5:18 PM
ovasileva mentioned this in T235414: Deploy core version of watchlist for AMC users.Oct 14 2019, 9:44 AM
ovasileva added a parent task: T235414: Deploy core version of watchlist for AMC users.
• alexhollender_WMF closed subtask T235534: [AMC] fix alignment of "Edit your list of watched pages as Invalid.Oct 15 2019, 4:38 PM
• alexhollender_WMF updated the task description. (Show Details)
• alexhollender_WMF assigned this task to Edtadros.Oct 15 2019, 4:41 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

I've created tasks for the two current issues. Moving this along.

Edtadros reassigned this task from Edtadros to • alexhollender_WMF.Oct 17 2019, 2:57 AM
Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist
play around on the page
❌ AC1: design of page should match the "Basic design" above, minus the issues called out in T235535 and T235536

The items listed as OK are for the issues called out above and on the image for convenience. The rest of the items differ from the "Basic design"

T225127.png (4×1 px, 560 KB)

Edtadros moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 17 2019, 2:58 AM

I moved it to Ready for Signoff out of habit. I blame myself and the team's high quality work.

Edtadros updated the task description. (Show Details)Oct 17 2019, 2:59 AM
Jdlrobson added a comment.Oct 21 2019, 5:10 PM

@alexhollender and @Jdlrobson to sync on the other bugs.

Jdlrobson added a comment.Oct 23 2019, 5:20 PM

@alexhollender stray semicolon is tracked in T233649
There's no bug for the new line but if you want it, you can make one... I think we can do it with the following rule:

.mw-userlink {
display: block;

clear: both;
}
Jdlrobson moved this task from Needs More Work to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 23 2019, 5:20 PM
• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Oct 23 2019, 11:02 PM
• alexhollender_WMF moved this task from Needs Design Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
In T225127#5599893, @Jdlrobson wrote:

@alexhollender stray semicolon is tracked in T233649
There's no bug for the new line but if you want it, you can make one...

Ok that's tracked here now T236328. We can resolve this task.

ovasileva closed this task as Resolved.Oct 24 2019, 9:13 AM
ovasileva claimed this task.

Resolving. Yay! @alexhollender - let me know if there's other issues to deployment, otherwise, let's schedule T235414: Deploy core version of watchlist for AMC users for Monday

Johan added a project: User-notice.Oct 24 2019, 10:54 AM
Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.
Trizek-WMF moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Oct 24 2019, 12:34 PM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Oct 30 2019, 12:29 PM
ovasileva closed subtask T235535: [AMC] fix alignment of "Edit your list of watched pages" button on AMC watchlist page as Resolved.Nov 4 2019, 10:08 AM
ovasileva closed subtask T235536: [AMC] fix alignment of "Saved filters" button on AMC watchlist page as Resolved.Nov 4 2019, 5:37 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits