Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T101246

Highlighted wikisyntax while editing articles [AOI]
Closed, ResolvedPublic
Actions

Assigned To
kaldari
Authored By
• KasiaWMDE
Jun 3 2015, 11:38 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Antanana
Arlolra
AS
• bzimport
Danmichaelo
• DannyH
View All 45 Subscribers
Tokens
"Like" token, awarded by Mysteriumen."Like" token, awarded by Trizek-WMF."Party Time" token, awarded by Elitre."Like" token, awarded by TerraCodes."Love" token, awarded by Liuxinyu970226."Love" token, awarded by Pearli123."Love" token, awarded by He7d3r."Love" token, awarded by Shizhao."Love" token, awarded by intracer."Love" token, awarded by Ricordisamoa."Love" token, awarded by Perhelion.

Description

As a Wikipedia editor I want to see highlighted wikisyntax while editing articles in sourcecode mode.

Further details:

See also

This task is #20 in the 2015 Community Wishlist survey.
This has also been one of the top 20 requests of the technical wishes survey in de-wiki in 2015

Details

SubjectRepoBranchLines +/-
[WIP] Syntax highlightermediawiki/extensions/WikiEditormaster+627 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedkaldariT101246 Highlighted wikisyntax while editing articles [AOI]
 ResolvedNiharikaT161054 Investigation: CodeMirror + New WikiText Editor performance issues
 ResolvedPastakhovT174547 Wrong cursor position after extension loads
 ResolvedNiharikaT161052 Investigation: CodeMirror + New WikiText Editor syncing issues
 ResolvedPastakhovT161475 CodeMirror forces loading of ext.wikiEditor module even when it isn't needed
 ResolvedReedyT108687 Security review for CodeMirror extension branch master
 ResolvedPastakhovT161694 Syntax highlighting: make <ref> tags and <nowiki> tags green
 ResolvedkaldariT163238 Integration of CodeMirror with other tag extensions
 ResolvedPastakhovT161559 Syntax highlighting: Better line spacing for H1s and H2s
ResolvedPastakhovT165001 Take out gray background behind list bullets in syntax highlighting
 ResolvedNiharikaT164806 Improve documentation for CodeMirror extension
 ResolvedSamwilsonT164441 Replace CodeMirror icons with new icons
 DeclinedNoneT164809 Fill scrolling gaps in syntax highlighting, take out larger font size and spacing for headers
 Resolved• NirzarT163919 Design review for CodeMirror extension
 ResolvedNiharikaT165178 Design fixes for text styles for codemirror
 ResolvedNiharikaT165003 Syntax highlighting popover for first-time user
 ResolvedNiharikaT169284 Deploy CodeMirror to testwiki
 ResolvedNiharikaT165543 Convert syntax highlighting into a Beta feature
 ResolvedNiharikaT95104 Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror
 ResolvedNiharikaT170966 Deploy CodeMirror on all Wikimedia wikis
 ResolvedMaxSemT185030 Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor
 ResolvedNiharikaT177804 Unexpected linebreaks added to edits
 ResolvedMusikAnimalT172456 Syntax highlighting - translate and tvar tags
 ResolvedFeatureAntiCompositeNumberT284883 CodeMirror – support highlighting the new <tvar> tag syntax
 ResolvedNikerabbitT274881 Change translation variable (tvar) syntax
 ResolvedMusikAnimalT179534 CodeMirror not recognizing Tableheaders on single text row
 ResolvedMusikAnimalT169592 Create unit tests for CodeMirror
 ResolvedMusikAnimalT185069 Incorrect syntax highlighting for: "//Text//" AND "//"
 ResolvedMusikAnimalT170238 Highlight void tags and other tags correctly
 ResolvedMusikAnimalT191297 Disable the "try syntax highlighting" popup for all users
 OpenNoneT170001 Support CodeMirror syntax highlighting on RTL wikis
 OpenMusikAnimalT358804 Add bidi isolation to HTML tags in CodeMirror 6
 OpenBUG REPORTNoneT360566 CodeMirror breaks on some large RTL pages
 OpenMusikAnimalT357482 2017 wikitext editor integration in CodeMirror 6
 ResolvedBUG REPORTMusikAnimalT373649 Copying and pasting large pages causes misalignment between CodeMirror and VE surfaces
 OpenBUG REPORTNoneT374072 CodeMirror 6 + 2017 wikitext editor race conditions
 ResolvedBUG REPORTMusikAnimalT374196 Text misaligned when switching directionality using CodeMirror in 2017 Source Editor
 OpenNoneT379104 Automatically detect and report misalignment between VE and CodeMirror surfaces
 ResolvedMaxSemT198537 Syntax Highlighting no longer remembers whether it should be on or off

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• DannyH added a subtask: T161475: CodeMirror forces loading of ext.wikiEditor module even when it isn't needed.Mar 27 2017, 9:08 PM
• DannyH added a subtask: T108687: Security review for CodeMirror extension branch master.
Dvorapa subscribed.Mar 28 2017, 4:39 AM
• DannyH added a subtask: T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.Apr 4 2017, 10:21 PM
• DannyH added a subtask: T161559: Syntax highlighting: Better line spacing for H1s and H2s .
kaldari closed subtask T161559: Syntax highlighting: Better line spacing for H1s and H2s as Resolved.Apr 6 2017, 12:12 AM
kaldari closed subtask T161475: CodeMirror forces loading of ext.wikiEditor module even when it isn't needed as Resolved.Apr 20 2017, 8:50 PM
TerraCodes awarded a token.Apr 25 2017, 2:06 AM
TerraCodes subscribed.
kaldari closed subtask T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green as Resolved.Apr 27 2017, 9:09 PM
• Elitre awarded a token.May 8 2017, 9:53 AM
Schnark subscribed.May 10 2017, 7:28 AM
• DannyH raised the priority of this task from Lowest to Medium.May 11 2017, 1:00 AM
• DannyH moved this task from Product backlog to Older: Tracking Work by Others on the Community-Tech board.
• DannyH added a subtask: T165001: Take out gray background behind list bullets in syntax highlighting.
• DannyH added a subtask: T164806: Improve documentation for CodeMirror extension.
• DannyH added a subtask: T164441: Replace CodeMirror icons with new icons.
• DannyH added a subtask: T164809: Fill scrolling gaps in syntax highlighting, take out larger font size and spacing for headers.May 11 2017, 1:02 AM
• DannyH added a subtask: T163919: Design review for CodeMirror extension.
• DannyH added a subtask: T165003: Syntax highlighting popover for first-time user.May 11 2017, 1:28 AM
kaldari closed subtask T165001: Take out gray background behind list bullets in syntax highlighting as Resolved.May 11 2017, 7:08 PM
Trizek-WMF subscribed.May 12 2017, 11:19 AM
kaldari closed subtask T164441: Replace CodeMirror icons with new icons as Resolved.May 21 2017, 3:07 PM
Herzi.Pinki mentioned this in T166098: Syntax sensitive and highlighting source code editor for template code wanted.May 23 2017, 1:05 PM
Herzi.Pinki subscribed.
Niharika reopened subtask T164441: Replace CodeMirror icons with new icons as Open.Jun 12 2017, 5:36 PM
• DannyH closed subtask T164441: Replace CodeMirror icons with new icons as Resolved.Jun 14 2017, 8:15 PM
• DannyH closed subtask T164809: Fill scrolling gaps in syntax highlighting, take out larger font size and spacing for headers as Declined.Jun 26 2017, 5:48 PM
Niharika closed subtask T165003: Syntax highlighting popover for first-time user as Resolved.Jun 29 2017, 10:13 PM
Niharika created subtask T169284: Deploy CodeMirror to testwiki.Jun 30 2017, 12:14 AM
Niharika added a subtask: T165543: Convert syntax highlighting into a Beta feature.Jun 30 2017, 12:36 AM
kaldari reopened subtask T165003: Syntax highlighting popover for first-time user as Open.Jun 30 2017, 11:25 PM
• DannyH closed subtask T163919: Design review for CodeMirror extension as Resolved.Jul 3 2017, 11:40 PM
kaldari closed subtask T165003: Syntax highlighting popover for first-time user as Resolved.Jul 6 2017, 5:37 PM
kaldari closed subtask T169284: Deploy CodeMirror to testwiki as Resolved.Jul 6 2017, 9:41 PM
• DannyH subscribed.Jul 6 2017, 9:55 PM

Syntax highlighting is now live on Test Wiki as a beta feature:

https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures

We're testing it this week before we deploy it to live wikis, so feel free to take a look, and leave comments here:

https://meta.wikimedia.org/wiki/Talk:Community_Tech/Wikitext_editor_syntax_highlighting

Trizek-WMF awarded a token.Jul 7 2017, 9:44 AM
kaldari closed subtask T164806: Improve documentation for CodeMirror extension as Resolved.Jul 12 2017, 10:56 PM
Jdforrester-WMF reopened subtask T165543: Convert syntax highlighting into a Beta feature as Stalled.Jul 18 2017, 9:08 PM
Niharika reopened subtask T164441: Replace CodeMirror icons with new icons as Open.Jul 20 2017, 10:45 PM
kaldari closed subtask T164441: Replace CodeMirror icons with new icons as Resolved.Aug 2 2017, 5:18 PM
Samwalton9-WMF unsubscribed.Aug 2 2017, 5:19 PM
Mysteriumen awarded a token.Aug 3 2017, 11:03 PM
jeblad updated the task description. (Show Details)Aug 4 2017, 7:13 AM
Jdforrester-WMF closed subtask T165543: Convert syntax highlighting into a Beta feature as Declined.Aug 4 2017, 4:11 PM
Jdforrester-WMF reopened subtask T165543: Convert syntax highlighting into a Beta feature as Stalled.
gerritbot added a comment.Aug 9 2017, 7:52 PM

Change 229616 abandoned by TheDJ:
[WIP] Syntax highlighter

Reason:
I think we can abandon this.

https://gerrit.wikimedia.org/r/229616

• DannyH closed subtask T165543: Convert syntax highlighting into a Beta feature as Resolved.Aug 23 2017, 5:09 PM
Restricted Application added a subscriber: Danmichaelo. · View Herald TranscriptAug 23 2017, 5:09 PM
• DannyH added a comment.Aug 23 2017, 5:11 PM

A heads-up for people who are watching this ticket: the Beta feature is live again on LTR projects.

Trizek-WMF added a subtask: T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror.Aug 24 2017, 10:20 AM
kaldari closed subtask T161054: Investigation: CodeMirror + New WikiText Editor performance issues as Resolved.Aug 24 2017, 8:32 PM
Reedy closed subtask T108687: Security review for CodeMirror extension branch master as Resolved.Aug 25 2017, 6:39 PM
Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 6:39 PM
SamanthaNguyen unsubscribed.Sep 18 2017, 6:37 PM
Niharika closed subtask T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror as Resolved.Oct 5 2017, 12:07 AM
Niharika closed subtask T161052: Investigation: CodeMirror + New WikiText Editor syncing issues as Resolved.Nov 7 2017, 11:56 PM
• TBolliger moved this task from Older: Tracking Work by Others to Older: Team Work on the Community-Tech board.Feb 14 2018, 6:41 PM
• TBolliger added a subtask: T170966: Deploy CodeMirror on all Wikimedia wikis.Feb 23 2018, 11:53 PM
• Lea_WMDE renamed this task from [GTWL] Epic: Highlighted wikisyntax while editing articles [AOI] to Highlighted wikisyntax while editing articles [AOI].Mar 9 2018, 11:01 AM
• Lea_WMDE updated the task description. (Show Details)
gh87 subscribed.Mar 19 2018, 8:12 PM

The feature works at the 2003/default WikiEditor (the one without the javascript-coded toolbars filled with buttons as seen in later WikiEditors). I just have to:

  1. Enable the Toolbar
  2. Enable the "Syntax Highlighting" feature in the Beta Preference
  3. Click the syntax highlighting button in the Toolbar
  4. Disable the Toolbar without disabling the feature

I can enable or disable the feature without disabling it in the Toolbar. More at https://meta.wikimedia.org/wiki/Talk:Community_Tech/Wikitext_editor_syntax_highlighting#Not_working_in_2003_WikiEditor_and_whether_to_enable_or_disable_by_default

I wonder whether a separate task is necessary.

kaldari closed this task as Resolved.Mar 19 2018, 9:06 PM
kaldari claimed this task.

Thanks, forgot to close this task!

gh87 added a project: SyntaxHighlight.Mar 19 2018, 11:39 PM
gh87 edited projects, added MediaWiki-extensions-CodeMirror; removed SyntaxHighlight.
gh87 mentioned this in T190108: Ways to opt-in/opt-out CodeMirror in 2003 Wikitext editor (without using the Toolbar).Mar 19 2018, 11:43 PM
MusikAnimal moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Mar 20 2018, 12:08 AM
Liuxinyu970226 unsubscribed.Mar 20 2018, 3:27 AM
gh87 unsubscribed.Mar 20 2018, 8:02 AM
Thgoiter unsubscribed.Mar 20 2018, 5:43 PM
• TBolliger closed subtask T170966: Deploy CodeMirror on all Wikimedia wikis as Resolved.Apr 11 2018, 10:56 PM
Jdforrester-WMF added a comment.Apr 12 2018, 7:42 PM
In T101246#4062642, @kaldari wrote:

Thanks, forgot to close this task!

I'm pretty sure this is meant to be the "for all users" task (i.e. the super-task of T185030 and T170001) and shouldn't be closed yet?

kaldari reopened this task as Open.Apr 12 2018, 9:53 PM

Good point. The feature is currently only available to logged-in users on some wikis, so it's only partially resolved.

• TBolliger added subtasks: T185030: Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor, T170001: Support CodeMirror syntax highlighting on RTL wikis.Apr 12 2018, 11:06 PM
• TBolliger merged a task: T18070: Highlighting possible internal links in the wiki editor.May 7 2018, 4:45 PM
• TBolliger added subscribers: • bzimport, • wikibugs-l-list.
Liuxinyu970226 moved this task from Done to Backlog on the MediaWiki-extensions-CodeMirror board.May 11 2018, 3:47 AM
Niharika closed subtask T185030: Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor as Resolved.Jun 14 2018, 5:39 PM
Liuxinyu970226 removed a subscriber: • wikibugs-l-list.Jun 15 2018, 1:45 PM
Liuxinyu970226 subscribed.
• TBolliger mentioned this in T191923: Enable CodeMirror in 2017 Wikitext editor in all LTR without the beta feature.Jun 21 2018, 3:59 PM
Niharika closed subtask T198537: Syntax Highlighting no longer remembers whether it should be on or off as Resolved.Jul 3 2018, 11:14 PM
Niharika added a comment.Jul 24 2018, 3:24 AM

CodeMirror has been deployed. Marking this as Resolved. Outstanding subtasks are stalled.

Niharika closed this task as Resolved.Aug 9 2018, 10:50 PM
In T101246#4446824, @Niharika wrote:

CodeMirror has been deployed. Marking this as Resolved. Outstanding subtasks are stalled.

Apparently I forgot to resolve this. The outstanding task about support of RTL wikis on standard editors can be dealt with outside of this. Support on RTL is available on the 2017 wikitext editor.

Liuxinyu970226 unsubscribed.Aug 12 2018, 3:25 AM
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Aug 28 2018, 1:26 PM
ECohen_WMDE mentioned this in T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.Sep 15 2020, 4:24 PM
TheresNoTime changed the status of subtask T170001: Support CodeMirror syntax highlighting on RTL wikis from Stalled to Open.Oct 23 2023, 12:34 PM
Stevietheman unsubscribed.Oct 23 2023, 6:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits