The Cancel button feature is implemented as VECancelButton extension

Is there a chance the patch will be reviewed?

Thanks, @Pppery. Actually, it is a duplicate because T286192 is not fixed yet fully. The master branch is crashed with the notifications were created before the patch applied to the source code.

This issue is not fixed. How do "the previous notifications from deleted pages on watchlist get deleted"? the patch https://gerrit.wikimedia.org/r/736484 fixes the issue for the newly created notifications because it adds the extra page_title and page_namespace parameters and then creates the Title object using ones. But for notifications created before the patch is applied, it crashes with the error message.

This should be fixed in https://github.com/SemanticMediaWiki/SemanticDrilldown/pull/48

@edwardspec, who can review the patch?

Thank you!

it works, tested on 1.35.0 (9b8a168)

In T267213#6669371, @ssastry wrote:

FWIW, I've worked with @Pastakhov of WikiTeq during the porting of Parsoid from JS to PHP and found them competent and well-qualified.

ALTER TABLE user CONVERT TO CHARACTER SET binary; helped me

Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PhpTags/+/610343

done

I think it is a good idea, 1.0 :)
thanks for the contributions!

Hi Yaron, I saw it, just mark "Set Ready For Review" when they ready and I'll +2 them.
I get notifications about all new patches, but ping me if I don't answer for a long time. Unfortunately, sometimes I may not notice something, sorry

I missed the patch, thanks for the ping

yes, I'm one, I'll fix it when I get some time

Hi, I still plan to work on this task

Hi, I still plan to work on this task

The file was uploaded with empty Summary field, I tried to rename (move) another file that was loaded with empty Summary field and I got the error.
how it looks in the database:

mysql> SELECT t.* FROM page t WHERE page_id = 99;
+---------+----------------+-------------------+-------------------+------------------+-------------+----------------+----------------+-------------+----------+--------------------+--------------------+-----------+
| page_id | page_namespace | page_title        | page_restrictions | page_is_redirect | page_is_new | page_random    | page_touched   | page_latest | page_len | page_content_model | page_links_updated | page_lang |
+---------+----------------+-------------------+-------------------+------------------+-------------+----------------+----------------+-------------+----------+--------------------+--------------------+-----------+
|      99 |              6 | KarlMarxJeune.jpg |                   |                0 |           1 | 0.621428611495 | 20190113233540 |         281 |        0 | wikitext           | 20180410093726     | NULL      |
+---------+----------------+-------------------+-------------------+------------------+-------------+----------------+----------------+-------------+----------+--------------------+--------------------+-----------+
1 row in set (0.00 sec)

I just successfully moved the file page after I adding text on the page, I think you don't face the issue because, as usual, all files contain text on wikipedia's file pages

debug info P9459

It seems this bug is not resolved yet.
I faced a similar problem on 1.33.0, when I'm trying to move page I got the error:

[0bff6a9515dc740c4d9e9790] /wr/index.php?title=Sp%C3%A9cial:Renommer_une_page&action=submit MediaWiki\Revision\IncompleteRevisionException from line 425 of /opt/mediawiki-1.33.1/includes/Revision/RevisionStore.php: sha1 field must not be ''!

In T69074#737261, @Rillke wrote:

after increasing memory to 204800 and restarting apache, it no more failed thumbnails for that reason -- still needs investigation

There is a few more errors because PHP 7.1 is more strictly related to the type of data, it is good but I need to process these incidents inside phptags too,
for example
php5.5 php7.0:
["4"] & "fff"; is ok
php 7.1
["4"] & "fff";

PHP Warning:  A non-numeric value encountered in Command line code on line 1

@hashar, thanks for looking at the failures. I debugged the problem, it happens because PHP 7 assigns the values in the list operator in reverted order (link).
I'll fix it soon

please, check it https://gerrit.wikimedia.org/r/#/c/435971/

Oh, sorry for delay, I try to update it right now

Oh, sorry. I got hard busy... I hope to continue in 2-3 weeks :-/

! In T174145#3652265, @kaldari wrote:
Note that we have to use an OOjs-UI icon for syntax highlighting within the 2017 Wikitext editor. That interface is constructed using OOjs-UI, so the only choices we have are the icons in https://github.com/wikimedia/oojs-ui/tree/master/src/themes/wikimediaui/images/icons.

looks like a virus :)

Seems should be fixed. Should be used different keyMaps for Mac and PC.

the path was rebased to the latest version of CodeMirror where the mentioned bug is fixed.

The status was changed by mistake... I did not want to do it by myself

ctrl + arrow key still working. Change 373624 makes behavior of alt + arrow key the same as when textarea used, see bug T174055.

Home / End keys cumbersome behavior

I think there should not be a big problem to make it resizable, and there should not be a problem with performance. I'll try to fix it.

can't reproduce on en.wikipedia.org

@Niharika yes, I understand about cost. I would prefer to find a balance between speed and ease of use.

Seems should be fixed with T174547

Should be merged with T174514

There is a bug: Home after End goes to the start of the next wrapped line. Hopefully it was fixed in latest CodeMirror library.

Solution is Better Home/End navigation with wrapped lines? #1576

The bug in the CodeMirror library Paste by using middle click in firefox not working #931

Maybe try to set viewportMargin to Infinity when ctrl+F pressed?

As a variant the patch above calls the CodeMirror.enabled and CodeMirror.disabled hooks.
Catching ones gets you full access to the CodeMirror features.
For example, alert message when the text is changed:

mediaWiki.hook( 'CodeMirror.enabled' ).add( 
    function ( cm ) { 
        cm.on( 'change', function() { 
            alert ( 'text changed' ); 
        } );
    } 
);

It used event change of CodeMirror.

Not sure for what the one was added by change 199941.

@Niharika I'm on a trip until September

Can't reproduce on en.wikipedia.beta.wmflabs.org

The bug described above happens on FF. Since WikiEditor does not designed to work with changeable icons, the one requires the icon defined when initializing. Because we use other approach to define the icons, WikiEditor inserts style to the button style="background-image: url("undefined");".
Despite the fact that it is removed later, FF trying load undefined background any case .

Possibly there is one other problem, I see the requests to /w/undefined when CodeMirror is enabled. Maybe problem is only on my test wiki, please check it on before the wide-scale deployment.

@Niharika It is easier to install the extension without composer usage and maybe when I created the extension composer was not widely used for mediawiki extensions (not sure).

@Niharika Maybe it is possible by process event:

"cursorActivity" (instance: CodeMirror)
    Will be fired when the cursor or selection moves, or any change is made to the editor content.

There are two problems:

1. font size can be changed only for whole line and big comments looks ugly for me.
2. processing comments required some optimizations of tokenizer, it should be able to change type of previous tokens without processing all next tokens again.

Take a look at my solution, maybe you'll find there something useful.
https://github.com/pastakhov/compose-mediawiki-ubuntu

Seems there is a hook that are called when Toolbar initialized, I am not sure...

Thanks for nice links ;-)

Yes, actually it is one task - make parser for [[File:...]]. One is parsed as a link still.

Wikitext syntax highlighting depend on mediawiki settings such as site language, extension installed and etc.
Thus it is not possible to make a general mediawiki mode аnd in the future this dependence will only increase.

@IKhitron, It does not work since there are only part of language aliases (localized magic words).
And as I wrote, I have no idea why there are only part of them.
In any case this behavior is a bug, CodeMirror should use only language from $wgLanguageCode and it will be fixed soon.
For check localized magic words you should set $wgLanguageCode to corresponded value or use the CodeMirror extension on wiki with $wgLanguageCode have corresponded value (it's no joke).

I found other way - add uselang parameter to url, but it is more a bag that a feature (and should be fixed)
For example https://test.wikipedia.org/w/index.php?title=Pride_and_Prejudice&action=edit&oldid=323245&uselang=de
Or change it by language toolbar at the top of page. But in this case I see only part of language aliases.
Have no idea why.

I meant that it depends on the value of the $wgLanguageCode variable.
On test.wikipedia.org it is en thus there are no Localized magic words.
For check localized magic words you should set $wgLanguageCode to corresponded value.

Such hard-to-reproduce bug report is like a diamond, thank you for testing and well describing.
Seems problem is in $( addCodeMirrorToWikiEditor );
The addCodeMirrorToWikiEditor function should be called after wikiEditor loaded. (should make sure that wikiEditor loaded).
This is really hard-to-reproduce.