Set Webauthn authentication challenge in prompt page #3324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## webauthn-cli #3324 +/- ##
================================================
- Coverage 98.59% 98.54% -0.05%
================================================
Files 116 116
Lines 3405 3426 +21
================================================
+ Hits 3357 3376 +19
- Misses 48 50 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
54d90fe to
7cf09a7
Compare
jenshenny
commented
Jan 6, 2023
| otp_or_recovery: | ||
| security_device: | ||
| verify_code: | ||
|
|
There was a problem hiding this comment.
from running bin/fill-locales
|
Codecov is failing because app/models/concerns/rubygem_searchable.rb coverage is decreased. This file is unrelated to this feature, and looking at the feature branch, it says that the coverage is increased in the file by the same percentage. I'm going to merge and hope that the change in coverage for the feature branch in that file will break even. |
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you solving?
Part of #3298
Stores webauthn authentication challenge on the webauthn verification page to use for credential verification.
If the user doesn't have webauthn devices, redirect to home with flash error.
What approach did you choose and why?
Storing the user id and challenge in the session. This is in line with the verification for web login https://github.com/Shopify/rubygems.org/blob/002480b704b1979a8e5db0d235ea8595ddfbc3a2/app/controllers/sessions_controller.rb#L143-L152
Testing
For when the user removes all webauthn devices before accessing the webauthn verification link