Generate webauthn verification otp #98
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: rubygems#3334
What problem are you solving?
Part of rubygems#3298
After successful verification of Webauthn credentials, an OTP needs generated to be sent to the client (either through manual pasting or sockets).
What approach did you choose and why?
SecureRandom.base58(20)
with 2 minute expiry.What should reviewers focus on?
SecureRandom.base58(20)
fine for the otp and 2 minutes as the expiry?Testing
WebauthnVerification.find_by(path_token: "4MFRajUpoARwmt9w").otp