[ONNX] Fix sum export with attribute keepdims (#59316) #60245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit dd5d0b8 (more details on the Dr. CI page and at hud.pytorch.org/pr/60245): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 18, 2021
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Fix after b9bdb07. Improving previous fix on two aspects * Not only checks 0 on first dimension for empty tensor. * Do not assume empty tensor when shape is not accessible. Co-authored-by: BowenBao <bowbao@microsoft.com> Differential Revision: [D29494917](https://our.internmc.facebook.com/intern/diff/D29494917) [ghstack-poisoned]
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@SplitInfinity merged this pull request in 4ccfa3f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix after b9bdb07. Improving previous fix on two aspects
Co-authored-by: BowenBao bowbao@microsoft.com
Differential Revision: D29494917