[ONNX] Fix shape inference for large model #59320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit a9124f7 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Install dependencies | 🔁 rerun |
ci.pytorch.org: 1 failed
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
fatcat-z
reviewed
Jun 3, 2021
9aa4084 to
a9124f7
Compare
BowenBao
added a commit
that referenced
this pull request
Jun 18, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com>
BowenBao
added a commit
that referenced
this pull request
Jun 18, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
This was referenced Jun 18, 2021
BowenBao
added a commit
that referenced
this pull request
Jun 18, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 21, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 22, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 22, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 23, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 25, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 30, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jul 6, 2021
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Co-authored-by: BowenBao <bowbao@microsoft.com> Differential Revision: [D29494910](https://our.internmc.facebook.com/intern/diff/D29494910) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
Summary: Pull Request resolved: #60244 Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens. Test Plan: Imported from OSS Reviewed By: zou3519, ZolotukhinM Differential Revision: D29494910 Pulled By: SplitInfinity fbshipit-source-id: 4c36d26de9a94e5d6cf78f332d4dffc46588ebf0 Co-authored-by: BowenBao <bowbao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{issue number}
Do 2GB size check for protocol buffer serialization at a later time, to avoid false alarming for cases like shape inference where no serialization actually happens.