g:doge_buffer_mappings (default 0) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option to use buffer mappings instead of normal mappings. Buffer mappings are enabled when DoGe is successfully started, and unmapped when finished.
kkoomen
reviewed
Sep 11, 2019
|
I optimized some code to follow the general project guidelines to make things consistent and I added tests. Thanks a lot for this PR. Very useful and big improvement on the plugin! I will merge it and want to release it with together with #45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option to use buffer mappings instead of normal mappings.
Buffer mappings are enabled when DoGe is successfully started, and
unmapped when finished.
Prelude
Thank you for helping out DoGe!
By contributing to DoGe you agree to the following statements (Replace
[ ]with[x]with those you agree with):Why this PR?
Same stuff of the PR #43, but cleaned up. The wrap-around feature has been moved to a different PR, since it's a different thing.
Reasons for the PR:
<tab>for DoGe, that is used sporadically and can use buffer mappings as other snippet plugins do