Use buffer mappings #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoomen
reviewed
Sep 8, 2019
kkoomen
reviewed
Sep 8, 2019
kkoomen
reviewed
Sep 9, 2019
|
FYI: I will check the tests later this week. |
<Tab> and <S-Tab> are the most obvious mappings, but to dedicate them to doge (and in all modes) is very demanding. Use buffer mappings instead, so that they are only active in 'doge-mode', and unmapped when finished. Deactivation is either automatic (end of placeholders, press outside of comment area) or manual (main mapping is pressed again).
Pressing <Tab> at the last placeholder would enter a tab, even if there are placeholders left before it, let it cycle back to the first one. Similarly, if currently at the first placeholder and pressing <S-Tab>, jump to the last placeholder.
Do not enable buffer mappings if g:doge_comment_interactive is false. Also use explicit check (v:true).
Pressing the main mapping after activation shouldn't trigger deactivation.
Default behaviour remains as it was. User must set g:doge_buffer_mappings to 1 if buffer mappings are preferred. Add option to documentation. Also made messages for activation/deactivation disabled by default (they're still undocumented).
Tests fail if cycling among placeholders is allowed by default, so I'm restricting this behaviour to the case that buffer mappings have been activated.
vint was complaining about local scopes and such
|
I rebased and made tests pass. Tests were probably failing because hitting Right now every difference is optional and must be enabled with |
|
This PR can be simplified a lot, I'm dumping it and making a new one. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prelude
Thank you for helping out DoGe!
By contributing to DoGe you agree to the following statements (Replace
[ ]with[x]with those you agree with):Why this PR?
<Tab>and<S-Tab>are the most obvious mappings, but to dedicate them todoge (and in all modes) is very demanding. Use buffer mappings instead,
so that they are only active in 'doge-mode', and unmapped when finished.
Deactivation is either automatic (end of placeholders, press outside of
comment area) or manual (main mapping is pressed again).
The first commit didn't give me troubles. The second commit requires some testing (I had a recursion once, then I changed it and it looks ok but some more testing is needed).