Fix #429: move from cabal-doctest to cabal repl -w doctest
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recreate the Haskell CI by typing `make ci` in the root.
Because of `cabal-version: 2.0`, stack wants an `extra-deps: [Cabal-2.0.0.1]` in the `stack-8.0.2.yaml` file, which in turn requires a `Setup.hs` present even for `build-type: simple`. (Don't as me, this is stack way of seeing the world.) I anyway doubt that anyone would want to insists on stack-installing BNFC with GHC 8.0. Principle: drop palaeo-GHCs as soon as they cause extra effort.
We include the commit SHA to ensure that caches always are written. Note: The stack.yaml does not track the dependencies. We would need stack.yaml.lock, but don't want this. We may use the .cabal file instead to get a better approximation. So far we didn't have any problems, so stick to the current strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #429: move from
cabal-doctesttocabal repl -w doctest.doctestssuite and thus thecabal-doctestdependency and thecustomsetup.make doctest, which will installdoctestper GHC version and invokecabal repl -w doctest.-Wno-type-defaultsghc option is needed for doctest to not stumble overOverloadedStrings. See:type-defaultswarnings (fromOverloadedStrings) make doctests fail sol/doctest#390cabal repl -w doctestto work in this environment.