Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of custom setup and cabal-doctest dependency #429

Closed
andreasabel opened this issue Oct 31, 2022 · 0 comments · Fixed by #433
Closed

Get rid of custom setup and cabal-doctest dependency #429

andreasabel opened this issue Oct 31, 2022 · 0 comments · Fixed by #433
Labels
build Building BNFC

Comments

@andreasabel
Copy link
Member

The custom setup in BNFC.cabal causes installation of the bnfc executable to require Cabal, which can take long to build.

bnfc/source/BNFC.cabal

Lines 70 to 74 in 220e985

custom-setup
setup-depends:
base >= 4 && <5,
Cabal >= 2.0,
cabal-doctest >= 1 && < 1.1

This is regrettable, since such a setup is only necessary as a means to enable doctest, yet a cabal install does not even provide means to run testsuites.
We should look into other ways than cabal-doctest to build the doctest driver.
@andreasabel andreasabel added the build Building BNFC label Oct 31, 2022
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: doctests via cabal repl -w doctest
eceeaec
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: doctests via cabal repl -w doctest
fb3bd8e
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: doctests via cabal repl -w doctest
8c29c2f
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: doctests via cabal repl -w doctest
e4fa815
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: doctests via cabal repl -w doctest
1c60e8e
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: doctests via cabal repl -w doctest
1bd0808
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Re #429: CI: patch for haskell-ci.yml to include doctest
750dcce 
Recreate the Haskell CI by typing `make ci` in the root.
andreasabel added a commit that referenced this issue Dec 16, 2022
@andreasabel
Fix #429: remove doctests suite and cabal-doctest dependency
9b3dce6
@andreasabel andreasabel mentioned this issue Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Building BNFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #429: move from cabal-doctest to cabal repl -w doctest BNFC/bnfc
1 participant
@andreasabel