Nothing Special   »   [go: up one dir, main page]

Closed Bug 1891544 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 45716 - Paint selection with other highlight parts

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45716 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45716
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

Paint selection with other highlight parts

When using the highlight overlay painting path, selection was
being painted as a separate step after the other highlight parts.
This resulted in double painting of non-selected text after a
recent CL, and also prevents selection from inheriting non-specified
colors from layers below.

This CL moves selection painting into the same loop as other highlight
parts, removing the double painting and making it possible, in the
next CL, to fix the color inheritance problem.

As a necessary substep:

  • Add a LineRelativeRect::Unite method
  • Add methods to adjust a line relative rect to match ink overflow
  • Add unit testing for LineRelativeRect
  • Add a cc file for LineRelativeRect.

And remove some of the fuzzy matching from a previous CL.

Bug: 40264572
Change-Id: Ic9a578895f363c85b0c2d2bb4e67dcb5b4159f5f
Reviewed-on: https://chromium-review.googlesource.com/5447735
WPT-Export-Revision: a30388eb582f42cfa1ed6c5508d0a447b0bc4251

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests

Status Summary

Firefox

PASS: 4
FAIL: 6

Chrome

PASS: 9
FAIL: 1

Safari

PASS: 4
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6216ca5a667c [wpt PR 45716] - Paint selection with other highlight parts, a=testonly https://hg.mozilla.org/integration/autoland/rev/d7ae589f6500 [wpt PR 45716] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.