Details

Reviewers

Group Reviewers

Commits

rMOZILLACENTRAL8c9ba927121c: Bug 1731541 - When line-clamp is in effect, make text-wrap:balance consider…
rMOZILLACENTRAL16a3de29e4e6: Bug 1731541 - When line-clamp is in effect, make text-wrap:balance consider…
rMOZILLACENTRAL7ce2b41bb730: Bug 1731541 - When line-clamp is in effect, make text-wrap:balance consider…

Bugzilla Bug ID

1731541

Summary

This corresponds to how Chrome behaves, and passes the test they included in WPT.

It's unclear to me whether this behavior actually follows from the current spec
(see https://github.com/w3c/csswg-drafts/issues/9310), but it seems to be the desired
result.

(I've put it behind a (default-enabled) pref for now, so that it's possible to
experiment with the two possible interpretations, but we can remove the pref once
the spec question is clarified/confirmed.)

This patch also disables balancing for fragmented/overflowing blocks, as that will
not currently work well. We may want to address that as a followup issue (though it
won't matter to the primary balance use-cases such as titles).

Depends on D188139

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

jfkthame created this revision.Sep 14 2023, 9:37 AM

Herald added a project: secure-revision. · View Herald TranscriptSep 14 2023, 9:37 AM

Harbormaster completed remote builds in B576850: Diff 763494.Sep 14 2023, 9:37 AM

phab-bot published this revision for review.Sep 14 2023, 9:37 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptSep 14 2023, 9:37 AM

jfkthame added a parent revision: D188139: Bug 1731541 - Add a few WPT reftests using text-wrap:balance together with floats. r=#layout-reviewers.Sep 14 2023, 3:30 PM

Rebase

Harbormaster completed remote builds in B580317: Diff 767149.Sep 23 2023, 1:19 PM

Code analysis found 2 defects in diff 767149:

2 defects found by clang-tidy

WARNING: Found 2 defects (warning level) that can be dismissed.

You can run this analysis locally with:

./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 767149.

jfkthame updated this revision to Diff 767314.Sep 25 2023, 10:14 AM

jfkthame edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B580461: Diff 767314.Sep 25 2023, 10:14 AM

emilio accepted this revision as: emilio.Sep 26 2023, 4:54 PM

emilio added a project: testing-approved.

emilio added inline comments.

layout/generic/nsBlockFrame.cpp
1453	This seems like it should be in the previous patch perhaps.

This revision is now accepted and ready to land.Sep 26 2023, 4:54 PM

jfkthame marked an inline comment as done.Sep 27 2023, 7:24 PM

jfkthame added inline comments.

layout/generic/nsBlockFrame.cpp
1453	Yes, it should (along with the checks of reflowStatus.IsFullyComplete). I was being lazy and minimizing churn in my local queue! Anyhow, I've now moved it to the earlier patch.