Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

CostasAthan
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2020, 5:05 PM (239 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Costas Athan [ Global Accounts ]

Recent Activity

Dec 3 2022

CostasAthan added a comment to T322143: Can't DROP FOREIGN KEY `echo_push_subscription_ibfk_2`; check that it exists.

Same problem while trying to upgrade from 1.38.2 to 1.39.0.

Dec 3 2022, 4:16 PM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Growth-Team (Sprint 0 (Growth Team)), MW-1.39-release, Notifications

Dec 27 2020

CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

My confusion about the writeapi right was cleared by starting this topic: https://www.mediawiki.org/wiki/Topic:Vw6wwobg89cw970u

Dec 27 2020, 11:54 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor

Oct 20 2020

CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

It will fix one of the two reasons you're getting the 403 error - VisualEditor not only requires the writeapi right, but also the edit right. AFAIK, you still have editing disabled for unregistered users.

Oct 20 2020, 11:11 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

It will fix one of the two reasons you're getting the 403 error - VisualEditor not only requires the writeapi right, but also the edit right. AFAIK, you still have editing disabled for unregistered users.

Oct 20 2020, 10:51 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

You were right that my initial assumption was wrong. Now I get:

Oct 20 2020, 10:37 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

Yes, it does, as is explained on https://www.mediawiki.org/wiki/Help:ApiSandbox

Just create a test page and try to delete that one with the API

Oct 20 2020, 10:15 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

which means that if I had defined these parameters (I didn't, because I don't want to actually delete any pages and I'm not sure if the API sandbox actually executes the requests) the unregistered user could proceed with the page deletion. Still there in no link for page deletion on the website, like it appears when I'm logged in, but it turns out the deletion could be completed through the API!

That is a false conclusion. The fact that the API tells you that you made an invalid request does not mean that a valid request would be allowed to execute. The API cannot check an invalid request for permissions (e.g. to delete a page) since it simply doesn't know what you want to do.

Oct 20 2020, 10:09 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

which means that if I had defined these parameters (I didn't, because I don't want to actually delete any pages and I'm not sure if the API sandbox actually executes the requests) the unregistered user could proceed with the page deletion. Still there in no link for page deletion on the website, like it appears when I'm logged in, but it turns out the deletion could be completed through the API!

No, it does not, you would have gotten an error if you submitted a valid request. Anyway, I don't care to argue with you about it.

Oct 20 2020, 10:05 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

I don't think that raises any such questions. '*' corresponds to all users, logged in or logged out.

I suggested the second line for clarity, assuming you had some crazy permissions settings already. If it was confusing, then please forget I ever wrote it there.

Oct 20 2020, 9:45 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor

Oct 17 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

If you are talking about the 403 error in my case that's the issue: T265043#6530768

Oct 17 2020, 7:24 AM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 16 2020

CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

Sorry, I didn't read your comment closely enough.

I don't think you want to use $wgRevokePermissions here. Per the docs: https://www.mediawiki.org/wiki/Manual:$wgRevokePermissions "Revoking a right with $wgRevokePermissions takes precedence over granting it with $wgGroupPermissions. If the right is revoked for even one of the user's groups, they will not have it, regardless of whether it's explicitly permitted by other groups."

(As I understand it, the purpose of $wgRevokePermissions is to allow "soft-banning" users, by adding them to a group that has all or most permissions revoked.)

Assuming you want to allow editing for logged in users, but not logged out users, I think you want this instead:

$wgGroupPermissions['*']['edit'] = false;
$wgGroupPermissions['user']['edit'] = true;
Oct 16 2020, 10:59 AM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor

Oct 15 2020

CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

You can use the 'user' group to assign permissions to logged in users.

Oct 15 2020, 10:10 PM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

No, I did it.

Oct 15 2020, 9:28 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 13 2020

CostasAthan removed a watcher for MediaWiki-extensions-CookieWarning: CostasAthan.
Oct 13 2020, 8:38 PM

Oct 8 2020

CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

Well, you could have www.mywiki.com use Cloudflare DNS and www.mywikiwithoutcloudflare.com use your hosting providers DNS.

Oct 8 2020, 9:15 PM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

Another thing that might work: set $wgVisualEditorFullRestbaseURL = https://DOMAIN_THAT_LEADS_TO_YOUR_WIKI_BUT_DOESNT_USE_CLOUDFLARE.com/rest.php

That way VisualEditor would bypass Cloudflare and you could use the IP solution with your servers IP address.

Oct 8 2020, 9:09 PM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

AFAIK, VisualEditor is not part of any group, so you need to find a way to enable edit and writeapi for * - but only if the requests come from VisualEditor. The solution described in T263928#6518831 does this, but since you are using Cloudflare and every request comes from a different IP, even if it is sent by the server itself, this doesn't work for you.

You could try comparing for the User Agent instead of the IP - VisualEditor uses the user agent VisualEditor-MediaWiki/1.35.0, afaik. However, keep in mind that this would open a security risk - everyone with that user agent could edit your wiki, and user agents can be easily changed/falsified.

Oct 8 2020, 9:07 PM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

OK. I found it.

Oct 8 2020, 8:50 PM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Judging by the log you provided above, the IP address you need to use should be 162.158.73.250.

Oct 8 2020, 8:35 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

In that case, you either need to apply the solution I described in T263928#6518831 or - if you are using HTTP only and no HTTPS - enable cookie forwarding as per https://www.mediawiki.org/wiki/Extension:VisualEditor#Forwarding_cookies_to_Parsoid. Keep in mind that if you enable cookie forwarding, you also have to manually configure Parsoid (https://www.mediawiki.org/wiki/Parsoid#Linking_a_developer_checkout_of_Parsoid).

Oct 8 2020, 8:08 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

When you visit the site (/rest.php/[domain]/v3/page/html/Main_Page/95?redirect=false&stash=true) with your browser, do you get a JSON that tells you "rest-write-denied" or do you get a 403 error message served by your webserver?

Oct 8 2020, 7:58 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan updated subscribers of T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Here is the log of the server:

Oct 8 2020, 7:48 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan created T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.
Oct 8 2020, 2:31 PM · Editing-team (Third-party), Parsoid (Third-party), MW-1.35-release, VisualEditor
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Based on this solution that worked for @D3nnis3n, I modified my .htaccess file, which also implements short URLs, like this:

Oct 8 2020, 6:56 AM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 5 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

No, I haven't. What I'm going to look at first though is what is the equivalent of @D3nnis3n solution for Nginx for an .htaccess file for Apache.

Oct 5 2020, 6:59 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

As I'm not familiar with Nginx, do you have an idea what the equivalent code for an .htaccess file would be?

Oct 5 2020, 6:51 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

I also have set my wiki to what you mention as semi-private mode. That's probably not a coincidence.

Oct 5 2020, 6:47 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

I'm not sure if the solutions work for everyone. I tried both of @ssastry's suggested solutions and neither one worked for me. The .htaccess solution gives me a 403 error instead of 404.

Oct 5 2020, 6:00 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 4 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).
'domain' => '....' // BY default, this is $wgServer,
Oct 4 2020, 8:11 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Should I consider this as an answer to my question? RESTBase doesn't come packed along with MediaWIki 1.35, right? Even if it is so, according to the documentation the only problem that arises is the one with the "dirty diffs".

Oct 4 2020, 5:06 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

The wiki mentions it does only need to be installed if you don't want 'dirty diffs' to happen when switching editors. So it should still work out-of-the-box.
I mean i don't need it to work out of the box, but i expected a bit of a documentation on how to set it up - currently there is neither a documentation nor is it working out of the box.

Oct 4 2020, 7:47 AM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 3 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Just a question. Parsoid comes packed along with MediaWiki 1.35. Does the same apply to RESTBase or should it get installed separately?

Oct 3 2020, 3:21 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 2 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

For me that code loads VisualEditor without the page's contents. I had achieved exactly the same behavior by just setting $wgVisualEditorFullRestbaseURL variable in LocalSettings.php

Oct 2 2020, 11:13 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release
CostasAthan added projects to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading): RESTBase, RESTBase-API.
Oct 2 2020, 3:52 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Oct 1 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

I don't think so. I always get the 404 error, not only with pages that have titles which contain specific characters.

Oct 1 2020, 10:21 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Sep 30 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Has anyone tried to recreate the problem?

Sep 30 2020, 9:16 AM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Sep 28 2020

CostasAthan added a comment to T263928: VisualEditor in 1.35 not working (404 / Permanent Loading).

Same problems for me too.

Sep 28 2020, 3:22 PM · Editing-team (Third-party), Parsoid (Third-party), RESTBase-API, RESTBase, VisualEditor, MW-1.35-release

Apr 11 2020

CostasAthan updated subscribers of T249248: CookieWarning's GDPR compliance.

Something I would like to bring to everyone's attention: An extension that embeds gtag.js to MediaWiki offers two ways of opting out from Google Analytics tracking:

Apr 11 2020, 4:12 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning

Apr 10 2020

CostasAthan updated subscribers of T249823: Enabling Structured discussions without console access.

Hi @Aklapper. I was instructed in the past by @Florian to start a new issue in Phabricator about a feature request, which I guess falls in the enhancement category you mentioned, and I hadn't realized Phabricator has a limited spectrum of purposes.
Your message is noted, but I guess my question could be rewritten as a request for a simplified method of installation for those running their wikis in shared servers with limited control of the environment, if that's of course possible.

Apr 10 2020, 10:11 AM · StructuredDiscussions, Growth-Team

Apr 9 2020

CostasAthan closed T249823: Enabling Structured discussions without console access as Resolved.

https://www.mediawiki.org/w/index.php?title=Topic:Vk6hsapb4n60rfzp&topic_showPostId=vk6r6ilrcag6paaz
User Ciencia Al Poder offered a solution.

Apr 9 2020, 3:56 PM · StructuredDiscussions, Growth-Team
CostasAthan created T249823: Enabling Structured discussions without console access.
Apr 9 2020, 2:38 PM · StructuredDiscussions, Growth-Team

Apr 3 2020

CostasAthan added a comment to T249248: CookieWarning's GDPR compliance.

That sounds impossible to do, as CookieWarning would need a way to intercept how scripts can be added and need to decide, if they should be loaded based on the consent given by the user, where the CookieWarning extension does not have any context to know that.

Apr 3 2020, 6:15 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning
CostasAthan added a comment to T249248: CookieWarning's GDPR compliance.

I added you by momentum. I guess adding someone to the subscribers is the appropriate way to go.

Apr 3 2020, 3:21 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning

Apr 2 2020

CostasAthan created T249248: CookieWarning's GDPR compliance.
Apr 2 2020, 5:24 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning
CostasAthan added a watcher for MediaWiki-extensions-CookieWarning: CostasAthan.
Apr 2 2020, 5:16 PM
CostasAthan removed a member for MediaWiki-extensions-CookieWarning: CostasAthan.
Apr 2 2020, 5:13 PM
CostasAthan added a member for MediaWiki-extensions-CookieWarning: CostasAthan.
Apr 2 2020, 5:12 PM