Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

Offboard Manuel (WMDE) from WMF systems
Closed, ResolvedPublic

Description

Manuel Merz (Wikitech user: Manuel Merz (WMDE), shell username and LDAP uid: manuel-wmde) is no longer a WMDE employee. As a WMDE Engineering Manager I request offboarding from WMF systems.

Potentially incomplete list of permissions involved:

  • Disable Phabricator account @Manuel
  • Disable Wikitech account
  • Remove from wmde LDAP group
  • Remove from nda LDAP group
  • Revoke production shell access (to confirm, I am not sure he was granted it)
  • Revoke WMF Analytics Data access (groups analytics-wmde-users, analytics-privatedata-users, airflow-wmde-admin)
  • Adjust priviliged LDAP access (data.yaml)
  • Revoke permission to create Phabricator projects (acl*Project-Admins)
  • Revoke permissions to access security Phabricator tasks (acl*security) (acl*security_wmde already revoked by the WMDE staff)
  • Revoke permissions to access private Phabricator tasks (WMF-NDA)

We might have missed some additional permissions that the user might have been granted. I'd appreciate if WMF staff audited that the person no longer have any staff-related access to WMF systems.

Event Timeline

andrea.denisse changed the task status from Open to In Progress.Wed, Sep 4, 5:38 PM

Hi @Aklapper , I'm unable to remove the from the acl*Project-Admins and acl*security Phabricator groups because I'm not an administrator of those groups.
Could you please grant me administrator access to them?

img-2024-09-04-11-46-15.png (361×848 px, 28 KB)

Change #1070653 had a related patch set uploaded (by Andrea Denisse; author: Andrea Denisse):

[operations/puppet@production] ldap: Offboard Manuel (WMDE) from WMF systems

https://gerrit.wikimedia.org/r/1070653

Change #1070653 merged by Andrea Denisse:

[operations/puppet@production] ldap: Offboard Manuel (WMDE) from WMF systems

https://gerrit.wikimedia.org/r/1070653

Aklapper updated the task description. (Show Details)

I'm unable to remove the from the acl*Project-Admins and acl*security Phabricator groups because I'm not an administrator of those groups.
Could you please grant me administrator access to them?

@andrea.denisse Hmm, I worry that it won't scale to manually both hand out administrator rights to individual SRE members and to remove them once folks moved on... Is there a strong reason why to remove a Phab account from such Phab project membership if that Phab account is disabled already anyway (obviously under the assumption that the account will remain disabled for good)?

Just for completeness, IIRC there's also emergency access via the @admin account (of course I cannot find the corresponding docs, meh).

I removed the account from the two groups for now.

I'm unable to remove the from the acl*Project-Admins and acl*security Phabricator groups because I'm not an administrator of those groups.
Could you please grant me administrator access to them?

@andrea.denisse Hmm, I worry that it won't scale to manually both hand out administrator rights to individual SRE members and to remove them once folks moved on... Is there a strong reason why to remove a Phab account from such Phab project membership if that Phab account is disabled already anyway (obviously under the assumption that the account will remain disabled for good)?

Just for completeness, IIRC there's also emergency access via the @admin account (of course I cannot find the corresponding docs, meh).

I removed the account from the two groups for now.

Thanks @Aklapper , as for removing a deactivated account from Phabricator's project I can't say for sure, but it was part of the checklist in the task description.

andrea.denisse updated the task description. (Show Details)

Hi @WMDE-leszek , the offboarding process for Manuel is complete.
Feel free to reopen this task if there's anything else I can help with.

Change #1071222 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Re-add and absent data.yaml entry for manuel-wmde

https://gerrit.wikimedia.org/r/1071222

Change #1071222 merged by Muehlenhoff:

[operations/puppet@production] Re-add and absent data.yaml entry for manuel-wmde

https://gerrit.wikimedia.org/r/1071222