Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

FlaggedRevs: RecentChanges filters no longer work
Closed, ResolvedPublicPRODUCTION ERROR

Description

Steps to replicate the issue (include links if applicable):

What happens?:
No changes are displayed.

What should have happened instead?:
There should be some changes listed - the ones that satisfy the selected criteria.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
When opening RC with a link with flaggedrevs filter already applied, an InvalidArgumentException is thrown ( https://pl.m.wikipedia.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&flaggedrevs=needreview&limit=500&days=30&enhanced=1&title=Specjalna:Ostatnie_zmiany&urlversion=2&uselang=en )

Screenshot_20240725_214222_Edge.jpg (588×1 px, 90 KB)

If possible, please revert the faulty change, it severely breaks patrolling on wikis with FR enabled.

Details

MediaWiki Version
1.43.0-wmf.15
Request URL
https://pl.m.wikipedia.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&flaggedrevs=needreview&limit=500&days=30&enhanced=1&title=Specjalna:Ostatnie_zmiany&urlversion=2&uselang=en

Event Timeline

Tacsipacsi changed the subtype of this task from "Bug Report" to "Production Error".Jul 25 2024, 8:07 PM
Tacsipacsi set Request URL to https://pl.m.wikipedia.org/w/index.php?hidebots=1&hidecategorization=1&hideWikibase=1&flaggedrevs=needreview&limit=500&days=30&enhanced=1&title=Specjalna:Ostatnie_zmiany&urlversion=2&uselang=en.Jul 25 2024, 8:09 PM
Tacsipacsi set Release Version to 1.43.0-wmf.15.
Tacsipacsi subscribed.

Change #1057011 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Revert "Use expression builder to avoid IDatabase::makeList"

https://gerrit.wikimedia.org/r/1057011

Change #1057012 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@wmf/1.43.0-wmf.15] Revert "Use expression builder to avoid IDatabase::makeList"

https://gerrit.wikimedia.org/r/1057012

I suggest merging the backport but not the patch on master. That'd make things easier and give you enough time to make proper fix.

Change #1057012 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.43.0-wmf.15] Revert "Use expression builder to avoid IDatabase::makeList"

https://gerrit.wikimedia.org/r/1057012

Mentioned in SAL (#wikimedia-operations) [2024-07-25T22:46:07Z] <ladsgroup@deploy1002> Started scap sync-world: Backport for [[gerrit:1057012|Revert "Use expression builder to avoid IDatabase::makeList" (T371052)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-25T22:48:30Z] <ladsgroup@deploy1002> ladsgroup, umherirrender: Backport for [[gerrit:1057012|Revert "Use expression builder to avoid IDatabase::makeList" (T371052)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-25T22:56:15Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:1057012|Revert "Use expression builder to avoid IDatabase::makeList" (T371052)]] (duration: 10m 08s)

Not merged on master

Change #1055612 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Use expression builder instead of raw sql

https://gerrit.wikimedia.org/r/1055612

Change #1057011 abandoned by Umherirrender:

[mediawiki/extensions/FlaggedRevs@master] Revert "Use expression builder to avoid IDatabase::makeList"

Reason:

Added a test to Iffbe09e07f9a58aeddc360f10aa44c68c4410e14

https://gerrit.wikimedia.org/r/1057011

Change #1055612 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use expression builder instead of raw sql

https://gerrit.wikimedia.org/r/1055612

Umherirrender claimed this task.