Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

Replace mediawiki.ui variables with mediawiki.skin.variables
Closed, ResolvedPublic

Assigned To
Authored By
Volker_E
Mar 20 2023, 8:45 AM
Referenced Files
None
Tokens
"Party Time" token, awarded by CCiufo-WMF.

Description

Background

Since MW v1.41.0 'mediawiki.skin.variables.less' features Codex design tokens. These are providing a themeable, scalable nomenclature and are following mediwiki.ui variables Wikimedia's stylesheet variable naming convention.

Goal

Replace 'mediawiki.ui/variables.less' @imports with 'mediawiki.skin.variables.less' and on the course also replace deprecated T319381 vars and static values where easily identifiable.

Benefits
  • Reduce design debt
  • Reduce technical debt
  • Ensure that single source of truth is clarified and established with Codex design tokens via skin variables
  • Extension developers benefit from skin aware tokens (vars). Extensions magically adapt to MW skins. The extent is still on extension author (for example only color tokens used, or everything)
Risks
  • The change requires MW v1.41, if your extension is required to be further backwards-compatible, please reach out to find intermediate solutions
  • As with every code change, there's a minimal chance of human error in token application. The patches provided should not result in visual change aside of a few major extension, where the known small changes are flagged.
Acceptance criteria for done

Related for mediawiki.skin.variables becoming single source of truth is T334934: [EPIC] Replace WikimediaUI Base variables with Codex design tokens (mediawiki.skin.variables)
The final step for mediawiki.ui/variables is tackled in T335822: Deprecate and remove mediawiki.ui variables

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/GrowthExperimentsmaster+537 -1 K
mediawiki/skins/MinervaNeuemaster+155 -197
mediawiki/extensions/UniversalLanguageSelectormaster+2 -2
mediawiki/extensions/ContentTranslationmaster+256 -241
mediawiki/extensions/UniversalLanguageSelectormaster+422 -80
mediawiki/extensions/Graphmaster+5 -5
mediawiki/extensions/Translatemaster+344 -20
mediawiki/extensions/Collectionmaster+17 -15
mediawiki/coremaster+4 -4
mediawiki/extensions/WikibaseLexememaster+33 -35
mediawiki/extensions/WikibaseQualityConstraintsmaster+27 -22
mediawiki/skins/Vectormaster+36 -41
mediawiki/coremaster+238 -235
mediawiki/coremaster+96 -98
mediawiki/extensions/SearchVuemaster+14 -11
mediawiki/extensions/CentralNoticemaster+0 -1
mediawiki/extensions/WikidataPageBannermaster+12 -7
mediawiki/extensions/AdvancedSearchmaster+25 -21
mediawiki/extensions/Wikisourcemaster+14 -12
mediawiki/extensions/CampaignEventsmaster+29 -24
mediawiki/extensions/ExternalGuidancemaster+16 -16
mediawiki/extensions/Flowmaster+174 -141
mediawiki/extensions/Echomaster+76 -78
mediawiki/extensions/MultimediaViewermaster+50 -55
mediawiki/extensions/TemplateWizardmaster+11 -11
mediawiki/extensions/RelatedArticlesmaster+9 -9
mediawiki/extensions/CheckUsermaster+28 -25
mediawiki/extensions/Kartographermaster+2 -2
mediawiki/extensions/IPInfomaster+6 -11
mediawiki/extensions/MobileFrontendmaster+121 -121
mediawiki/extensions/InputBoxmaster+6 -6
mediawiki/coremaster+102 -89
mediawiki/extensions/CirrusSearchmaster+14 -14
mediawiki/extensions/WikiEditormaster+49 -36
mediawiki/extensions/Inboxmaster+3 -3
mediawiki/extensions/FileImportermaster+10 -10
mediawiki/skins/Metrolookmaster+2 -8
mediawiki/extensions/Popupsmaster+43 -33
mediawiki/extensions/Wikistoriesmaster+121 -114
mediawiki/extensions/MsUploadmaster+25 -26
mediawiki/extensions/QuickSurveysmaster+6 -6
mediawiki/extensions/EntitySchemamaster+12 -12
mediawiki/extensions/DiscussionToolsmaster+27 -35
mediawiki/coremaster+16 -2
mediawiki/coremaster+58 -33
mediawiki/extensions/Wikistoriesmaster+2 -2
mediawiki/extensions/CampaignEventsmaster+5 -5
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 904254 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904254

Change 909723 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909723

Change 904257 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/904257

Change 906773 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906773

@Volker_E just confirming -- this should be in "Code Review" not "Blocked" on the sprint board, right?

or is it blocked on T334790?

Change 910420 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/AdvancedSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/910420

@CCiufo-WMF In the past if we haven't had full control about dependencies, in this case needing other teams to review the patches and agree with the architecture, we've put tasks into the “Blocked” column. Only if we alone are responsible to get it through the sprint process steps, it was supposed to move cols. Has anything been clarified around this take @ldelench_wmf?

Change 904886 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904886

Change 909666 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909666

Change 910420 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/910420

Change 910821 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CentralNotice@master] styles: Remove unnecessary 'mediawiki.ui/variables' import

https://gerrit.wikimedia.org/r/910821

Change 910821 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] styles: Remove unnecessary 'mediawiki.ui/variables' import

https://gerrit.wikimedia.org/r/910821

Change 910865 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Remove 'mediawiki.ui/variables' call

https://gerrit.wikimedia.org/r/910865

Sounds like "blocked" and "code review" both work here if we're blocked on code reviews from other teams.

Change 906786 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906786

Change 908519 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.widgets, mediawiki.ui: Use skin variables

https://gerrit.wikimedia.org/r/908519

Change 909245 merged by jenkins-bot:

[mediawiki/core@master] RCFilters: Use skin variables

https://gerrit.wikimedia.org/r/909245

Change 910865 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Remove 'mediawiki.ui/variables' call

https://gerrit.wikimedia.org/r/910865

Change 906791 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906791

Change 900810 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] styles: Replace 'mediawiki.ui/variables'

https://gerrit.wikimedia.org/r/900810

Change 906785 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906785

Change 913145 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.special: Replace mediawiki.ui variables with skin vars

https://gerrit.wikimedia.org/r/913145

Change 913145 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.special: Replace mediawiki.ui variables with skin vars

https://gerrit.wikimedia.org/r/913145

Change 904252 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904252

Change 913634 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ContentTranslation@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/913634

Test wiki created on Patch demo by KHarlan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cfdfa13682/w

Change 914725 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Graph@master] styles: Use MediaWiki skin variables for all colors and borders

https://gerrit.wikimedia.org/r/914725

Change 909722 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] styles: Replace 'mediawiki.ui/variables' call with Codex design tokens

https://gerrit.wikimedia.org/r/909722

Change 914725 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] styles: Use MediaWiki skin variables for all colors and borders

https://gerrit.wikimedia.org/r/914725

Change 904259 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904259

Change 915101 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ext.uls.mixins: Use LESS variables from skin

https://gerrit.wikimedia.org/r/915101

Change 913634 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/913634

Change 915101 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ext.uls.mixins: Use LESS variables from skin

https://gerrit.wikimedia.org/r/915101

Hey @Volker_E this seems to have caused a UI regression: T335932. Could you please take a look?

Hey @Volker_E this seems to have caused a UI regression: T335932. Could you please take a look?

Fixed!

Change 901217 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/901217

Volker_E claimed this task.
Volker_E updated the task description. (Show Details)

Successfully resolved! ✨

Test wiki on Patch demo by KHarlan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/cfdfa13682/w/