Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

The sticky "Add topic" button behaves inconsistently when scrolled to the top of a talk page on iOS
Closed, ResolvedPublic

Description

We have recently changed the way the "Add topic" button appears/disappears in T316175. While it's mostly working fine in all four cases as directed in the mockups on the task, there are some inconsistencies in the way it re-appears when scrolled to the top of a talk page. It seems sometimes it does not re-appear at all. When it does it's not persistent and disappears immediately, which isn't helpful.

Check the screen capture below.

Event Timeline

Ryasmeen renamed this task from The sticky "Add topic" button behaves inconsistently when scrolled to the top of a talk page to The sticky "Add topic" button behaves inconsistently when scrolled to the top of a talk page on iOS.Nov 18 2022, 7:16 PM

Confirmed locally that the over-scroll "bounce" reports a negative scroll offset for the page, and is it animates back to a 0 scroll offset, then registers as scrolling down. This should be fixable capping negative values to 0.

Change 861856 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Ignore negative page scroll values on iOS

https://gerrit.wikimedia.org/r/861856

Change 861856 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Ignore negative page scroll values on iOS

https://gerrit.wikimedia.org/r/861856

Next step
This patch for this fix should be backported at the same time as T321961.

ppelberg moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
ppelberg added a project: Editing QA.
ppelberg moved this task from Inbox to High Priority on the Editing QA board.