Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T266267

Prefill keys when adding an object
Closed, ResolvedPublic
Actions

Description

Currently, when we add an object, and then select the type for the object, the object is created without a single key, and then we have to manually add all keys.

The system could read the type specification, and add all keys for the given type.

Current:

Screenshot 2020-10-22 at 11.00.49.png (283×879 px, 38 KB)

After:

Screenshot 2020-10-22 at 11.01.32.png (370×864 px, 51 KB)

Details

SubjectRepoBranchLines +/-
Prefill keys when ZObject is initializedmediawiki/extensions/WikiLambdamaster+5 -0
Follow Wikimedia Vue coding conventions for api calls and improvement for key prefillmentmediawiki/extensions/WikiLambdamaster+18 -15
Prefill keys when adding an objectmediawiki/extensions/WikiLambdamaster+17 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DVrandecic created this task.Oct 22 2020, 5:59 PM
DVrandecic updated the task description. (Show Details)
Jdforrester-WMF added a subtask: T264828: Get list of types and their keys from wiki, including labels in requested language.Oct 22 2020, 6:28 PM
DVrandecic moved this task from To triage to Phase γ on the Abstract Wikipedia team board.Oct 22 2020, 6:44 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase γ); removed Abstract Wikipedia team.
DVrandecic triaged this task as Lowest priority.Oct 22 2020, 6:46 PM
Jdforrester-WMF added a project: WikiLambda Front-end.Oct 22 2020, 6:48 PM
DVrandecic raised the priority of this task from Lowest to Low.Jan 13 2021, 5:36 PM
DVrandecic raised the priority of this task from Low to Medium.
gerritbot added a comment.Jan 14 2021, 6:38 PM

Change 656241 had a related patch set uploaded (by Gabrielchihonglee; owner: Gabrielchihonglee):
[mediawiki/extensions/WikiLambda@master] Prefill keys when adding an object

https://gerrit.wikimedia.org/r/656241

gerritbot added a project: Patch-For-Review.Jan 14 2021, 6:38 PM
Jdforrester-WMF assigned this task to Gabrielchl.Jan 14 2021, 6:48 PM
ArthurPSmith closed subtask T264828: Get list of types and their keys from wiki, including labels in requested language as Resolved.Jan 14 2021, 6:51 PM
gengh subscribed.Jan 20 2021, 4:43 PM

Some possible improvements over current behavior can be:

  • Adapt the API call to follow the Vuex store pattern: when adding an object, we can ask the store if it has the Zid information available, it will only follow through and make the API call if the Zid has not been fetched yet. The action fetchZkeys already does that, and handles the storage of both Zids and labels, so this could be used here as well.
  • When a type is selected during creation, initialize it with the labels as well.
  • When the type is changed, apart from adding the new labels, remove the labels that belonged to the previous type.
gerritbot added a comment.Jan 20 2021, 5:06 PM

Change 656241 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Prefill keys when adding an object

https://gerrit.wikimedia.org/r/656241

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 5:10 PM
gerritbot added a comment.Jan 23 2021, 10:37 PM

Change 658011 had a related patch set uploaded (by Gabrielchihonglee; owner: Gabrielchihonglee):
[mediawiki/extensions/WikiLambda@master] Follow Wikimedia Vue coding conventions for api calls and improvement for key prefillment

https://gerrit.wikimedia.org/r/658011

gerritbot added a project: Patch-For-Review.Jan 23 2021, 10:37 PM
gerritbot added a comment.Jan 25 2021, 1:10 PM

Change 658011 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Follow Wikimedia Vue coding conventions for api calls and improvement for key prefillment

https://gerrit.wikimedia.org/r/658011

DVrandecic raised the priority of this task from Medium to High.Jan 27 2021, 5:18 PM
gerritbot added a comment.Feb 4 2021, 9:56 PM

Change 661811 had a related patch set uploaded (by Gabrielchihonglee; owner: Gabrielchihonglee):
[mediawiki/extensions/WikiLambda@master] Prefill keys when ZObject is init-ed

https://gerrit.wikimedia.org/r/661811

gerritbot added a comment.Feb 5 2021, 3:47 PM

Change 661811 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Prefill keys when ZObject is initialized

https://gerrit.wikimedia.org/r/661811

Jdforrester-WMF removed a project: Patch-For-Review.Feb 10 2021, 5:24 PM
DVrandecic closed this task as Resolved.Feb 10 2021, 5:24 PM

Thank you, Gabriel, Geno!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits