persistently editable Grammatical Feature of a Form via the UI (M)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	daniel
	Aug 21 2017, 4:14 PM

Description

Right now the grammatical features of a form are editable. However the edit is not persistently stored. The edit a user makes via the UI should be persistently stored and survive a page reload.

Acceptence Criteria:

User can add a grammatical feature in the UI and save it, reload the page and see the edited grammatical feature
We will create a new API-Module for this (sub-task)

Details

Subject	Repo	Branch	Lines +/-
Use `FormSet` inside of the `Lexeme` class	mediawiki/extensions/WikibaseLexeme	master	+22 -12
Add assertions to ensure `$nextFormId` correctness in Lexeme	mediawiki/extensions/WikibaseLexeme	master	+95 -8
Introduce FormSet to simplify Lexeme state control	mediawiki/extensions/WikibaseLexeme	master	+142 -0
Serialize/deserialize nextFormId field of Lexeme	mediawiki/extensions/WikibaseLexeme	master	+62 -43
Add ChangeOp for Form addition	mediawiki/extensions/WikibaseLexeme	master	+115 -0
Consider forms when compare Lexemes for equality	mediawiki/extensions/WikibaseLexeme	master	+46 -0
Add `addForm` method to Lexeme	mediawiki/extensions/WikibaseLexeme	master	+68 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
Resolved	Addshore	T168260 Deploy WikibaseLexeme extension on Wikimedia cluster
Resolved	Addshore	T191457 Deploy WikibaseLexeme on www.wikidata.org
Resolved	Addshore	T191458 Deploy WikibaseLexeme on test.wikidata.org
Resolved	Lydia_Pintscher	T168263 WikibaseLexeme functional baseline
Resolved	Lydia_Pintscher	T159703 [Tracking] Support for Forms and Senses
Resolved	Lydia_Pintscher	T150178 Wikidata 2017 Q2 goals
Resolved	Lydia_Pintscher	T169708 Wikidata 2017 Q3 goals
Resolved	Lydia_Pintscher	T160052 [Epic] Support for Forms
Resolved	Lydia_Pintscher	T160525 [Story] Grammatical Feature of a Form
Resolved	None	T173742 persistently editable Grammatical Feature of a Form via the UI (M)
Resolved	• Aleksey_WMDE	T176473 [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer
Resolved	WMDE-leszek	T184409 Create the API module allowing editing the representation, and the grammatical features of a Form (days: 4)
Resolved	Lydia_Pintscher	T184411 UI: Use the API to save edits of grammatical features of the form (days: 1)
Resolved	None	T184702 Set the edit summary when editing the representation and/or grammatical features of the form

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

daniel added a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Aug 21 2017, 4:14 PM

Lydia_Pintscher added a project: Wikidata-Former-Sprint-Board.Sep 5 2017, 2:06 PM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.

• Aleksey_WMDE claimed this task.Sep 7 2017, 3:48 PM

Change 376537 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add addForm method to Lexeme

https://gerrit.wikimedia.org/r/376537

gerritbot added a project: Patch-For-Review.Sep 7 2017, 3:49 PM

• Aleksey_WMDE moved this task from Backlog to Doing on the Wikidata-Former-Sprint-Board board.Sep 7 2017, 3:49 PM

• Aleksey_WMDE mentioned this in rEWLE6a8ac595d935: Add `addForm` method to Lexeme.Sep 7 2017, 3:49 PM

• Aleksey_WMDE mentioned this in rEWLE41acd924994b: Add `addForm` method to Lexeme.

Change 376539 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Consider forms when compare Lexemes for equality

https://gerrit.wikimedia.org/r/376539

• Aleksey_WMDE mentioned this in rEWLE362ae3091022: Consider forms when compare Lexemes for equality.Sep 7 2017, 3:53 PM

Change 376540 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add ChangeOp for Form addition

https://gerrit.wikimedia.org/r/376540

• Aleksey_WMDE mentioned this in rEWLEb71a01588cbd: Add ChangeOp for Form addition.Sep 7 2017, 3:58 PM

Change 376044 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Add form API module

https://gerrit.wikimedia.org/r/376044

• Aleksey_WMDE mentioned this in rEWLE2f2e68c1f1ce: [WIP] Add form API module.Sep 7 2017, 3:59 PM

• Aleksey_WMDE mentioned this in rEWLE76ebb40faa6b: Serialize/deserialize nextFormId field of Lexeme.Sep 7 2017, 5:03 PM

Change 376558 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Introduce FormSet to simplify Lexeme state control

https://gerrit.wikimedia.org/r/376558

• Aleksey_WMDE mentioned this in rEWLE8e4c3f9b5fd6: Introduce FormSet to simplify Lexeme state control.Sep 7 2017, 5:47 PM

Change 376703 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add assertions to ensure $nextFormId correctness in Lexeme

https://gerrit.wikimedia.org/r/376703

Change 376704 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Add form API module

https://gerrit.wikimedia.org/r/376704

• Aleksey_WMDE mentioned this in rEWLE50135a297928: Add assertions to ensure `$nextFormId` correctness in Lexeme.Sep 8 2017, 11:13 AM

• Aleksey_WMDE mentioned this in rEWLEfbeceb1856bb: [WIP] Add form API module.

Change 376705 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use FormSet inside of the Lexeme class

https://gerrit.wikimedia.org/r/376705

• Aleksey_WMDE mentioned this in rEWLEabbc0d666a93: Use `FormSet` inside of the `Lexeme` class.Sep 8 2017, 11:18 AM

• Aleksey_WMDE mentioned this in rEWLE4f1dffd42610: [WIP] Add form API module.

WMDE-leszek mentioned this in rEWLEb2a4b7d0a52c: Serialize/deserialize nextFormId field of Lexeme.Sep 8 2017, 12:32 PM

WMDE-leszek mentioned this in rEWLEe12a62539fde: Add assertions to ensure `$nextFormId` correctness in Lexeme.Sep 8 2017, 12:36 PM

WMDE-leszek mentioned this in rEWLE598ab7d10f74: Introduce FormSet to simplify Lexeme state control.

WMDE-leszek mentioned this in rEWLE73ab157dc44e: Use `FormSet` inside of the `Lexeme` class.Sep 8 2017, 12:39 PM

WMDE-leszek mentioned this in rEWLE725cb432c617: [WIP] Add form API module.

Change 376537 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add addForm method to Lexeme

https://gerrit.wikimedia.org/r/376537

Change 376539 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Consider forms when compare Lexemes for equality

https://gerrit.wikimedia.org/r/376539

Change 376540 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add ChangeOp for Form addition

https://gerrit.wikimedia.org/r/376540

Change 376044 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Serialize/deserialize nextFormId field of Lexeme

https://gerrit.wikimedia.org/r/376044

Change 376558 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce FormSet to simplify Lexeme state control

https://gerrit.wikimedia.org/r/376558

• Aleksey_WMDE mentioned this in rEWLE23a03676bf7f: Add assertions to ensure `$nextFormId` correctness in Lexeme.Sep 11 2017, 3:43 PM

• Aleksey_WMDE mentioned this in rEWLE5f7a81526a93: Use `FormSet` inside of the `Lexeme` class.Sep 11 2017, 4:27 PM

Change 376703 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add assertions to ensure $nextFormId correctness in Lexeme

https://gerrit.wikimedia.org/r/376703

• Aleksey_WMDE mentioned this in rEWLE4ee1e8a9b3af: Use `FormSet` inside of the `Lexeme` class.Sep 11 2017, 4:49 PM

• Aleksey_WMDE mentioned this in rEWLE730eb8d50742: Use `FormSet` inside of the `Lexeme` class.Sep 11 2017, 5:03 PM

Change 376705 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use FormSet inside of the Lexeme class

https://gerrit.wikimedia.org/r/376705

WMDE-leszek mentioned this in rEWLE6aef744f9e76: [WIP] Add form API module.Sep 13 2017, 2:50 PM

WMDE-leszek mentioned this in rEWLE4a0c119e3849: [WIP] Add form API module.Sep 14 2017, 12:13 PM

WMDE-leszek mentioned this in rEWLE3447917fda28: [WIP] Add form API module.Sep 15 2017, 1:37 PM

WMDE-leszek mentioned this in rEWLEd2bc871b718f: [WIP] Add form API module.Sep 18 2017, 10:37 AM

WMDE-leszek mentioned this in rEWLE43bcd8fa21e0: [WIP] Add form API module.Sep 18 2017, 2:29 PM

WMDE-leszek mentioned this in rEWLEf5057c6d1050: [WIP] Add form API module.

• Aleksey_WMDE mentioned this in rEWLEdda9eb05efb3: [WIP] Add form API module.Sep 19 2017, 11:16 AM

• Aleksey_WMDE added a subtask: T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer.Sep 22 2017, 11:43 AM

WMDE-leszek moved this task from Doing to Proposed on the Wikidata-Former-Sprint-Board board.Oct 6 2017, 11:26 AM

thiemowmde closed subtask T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer as Resolved.Oct 9 2017, 10:16 AM

Liuxinyu970226 subscribed.Oct 9 2017, 10:16 AM

thiemowmde updated the task description. (Show Details)Oct 12 2017, 8:03 AM

WMDE-leszek moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.Oct 13 2017, 1:14 PM

WMDE-leszek moved this task from Backlog to Proposed on the Wikidata-Former-Sprint-Board board.

WMDE-leszek removed • Aleksey_WMDE as the assignee of this task.Oct 16 2017, 8:20 AM

WMDE-leszek moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.

WMDE-leszek added a subscriber: • Aleksey_WMDE.

Franziska_Heine renamed this task from [Story] Editable Grammatical Feature of a Form (presistent) to [Story] Editable Grammatical Feature of a Form (presistent) (S if we do T173742 first).Oct 24 2017, 1:20 PM

Franziska_Heine updated the task description. (Show Details)

Lydia_Pintscher removed a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Oct 24 2017, 2:28 PM

Lydia_Pintscher moved this task from incoming to big tasks on the Wikidata Lexicographical data board.Oct 24 2017, 2:34 PM

Lydia_Pintscher renamed this task from [Story] Editable Grammatical Feature of a Form (presistent) (S if we do T173742 first) to persistently editable Grammatical Feature of a Form (S if we do T173742 first).Oct 24 2017, 3:17 PM

Lydia_Pintscher renamed this task from persistently editable Grammatical Feature of a Form (S if we do T173742 first) to persistently editable Grammatical Feature of a Form via the UI (S if we do T173742 first).Oct 24 2017, 3:35 PM

Lydia_Pintscher updated the task description. (Show Details)Oct 24 2017, 3:43 PM

WMDE-leszek updated the task description. (Show Details)Oct 25 2017, 9:43 AM

thiemowmde mentioned this in T178994: [Task] Consistently use interfaces in the WikibaseLexeme code base.Oct 25 2017, 12:26 PM

I believe the title should have T173744 instead of a link to this ticket itself.

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Dec 18 2017, 2:40 PM

Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.Dec 18 2017, 2:43 PM

Lucas_Werkmeister_WMDE renamed this task from persistently editable Grammatical Feature of a Form via the UI (S if we do T173742 first) to persistently editable Grammatical Feature of a Form via the UI (M).Jan 2 2018, 2:22 PM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Sprint-2018-01-03; removed Patch-For-Review.

Lucas_Werkmeister_WMDE mentioned this in T173744: persistently addable/editable/removable Representations of a Form via the UI (M).

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Jan 2 2018, 2:50 PM

@Jonas brought an interesting issue which is of relevance here. The background is the decision documented in https://phabricator.wikimedia.org/T173744#3691083, which also applies for editing grammatical features. I'll let @Jonas elaborate more on the issue itself, as he's the person to explain this. Thanks!