Reduce memory copies of serialized buffers #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aPere3
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Hey @youben11 !
Thanks a lot for the PR, this is a very welcome improvement. On a general note, I would say that:
- The explicit casting is much much better. Thanks for that.
- The overloading of the
fromProtoI am not convinced. I would rather go for a two different entry points (likefromProtoMessageandfromProtoReader) to make things even clearer. This is essentially a matter of taste though, so feel free to ignore :)
Other than that, it looks good !
Readers were automatically casted to Messages which cost a memory copy. It's now required to explicitly make this conversion (copy).
5b5dcf2 to
b0cd9a2
Compare
BourgerieQuentin
approved these changes
Dec 10, 2024
compilers/concrete-compiler/compiler/lib/Bindings/Python/CompilerAPIModule.cpp
Show resolved
Hide resolved
reduce memory usage by avoiding unecessary copy
we inline the server key serialization so that we only make small copies
b0cd9a2 to
98c60ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readers were automatically casted to Messages which cost a memory copy. It's now required to explicitly make this conversion (copy).