User Profile: Navigate tabs by arrow keys when user profile opens. #28742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanagr
reviewed
Jan 30, 2024
fcad9fe to
f77e545
Compare
timabbott
reviewed
Feb 13, 2024
| @@ -463,6 +463,9 @@ export function show_user_profile(user, default_tab_key = "profile-tab") { | |||
| const $elem = toggler.get(); | |||
| $elem.addClass("large allow-overflow"); | |||
| $("#tab-toggle").append($elem); | |||
| setTimeout(() => { | |||
| $(".ind-tab.first").trigger("focus"); | |||
| }, 0); | |||
There was a problem hiding this comment.
So I believe with upcoming PRs, it'll be possible to have a different tab from the first one be initially selected (See #28445). Can you tweak this to focus the currently selected tab instead?
Left/right keys arrows in User Profile now navigates between tabs when it's first opened. Fixes zulip#28615
f77e545 to
14907ae
Compare
|
@timabbott updated the code so that if now focuses on the current selected tab instead. |
|
@amanagr is this ready for integration review? |
|
LGTM |
|
Merged, thanks @nimishmedatwal and @amanagr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left/right keys arrows in User Profile now navigates between tabs when the modal is first opened.
This issue was pointed out by @amanagr here
Fixes: #28615
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: