Add fragment_query generic extractor arg for DASH and native HLS
#5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
9 tasks
pukkandan
requested changes
Nov 20, 2022
hls_segment_query extractor argfragment_query generic extractor arg for DASH and native HLS
pukkandan
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DASH and HLS streams require the query from the manifest URL to be appended to its segment/fragment URLs as well, even if the segment/fragment URLs listed in the media playlist or manifest do not have any query.
A couple examples:
#4786 (comment)
#5604
This PR:
extra_param_to_segment_url(the native HLS downloader already supported this)fragment_query, which when passed will add the manifest URL's query to the info_dict'sextra_param_to_segment_urlfieldUsage:
yt-dlp --extractor-args generic:fragment_query "GENERIC_M3U8_OR_MPD_URL"Unfortunately this will not work with ffmpeg.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?