Add unit tests for serialization in ToolEnum. #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks the following invariant:
fromString(toString(x)) == x
for all enum values of ToolSize and ToolType.
This check is motivated by a bug discovered, where this invariant failed
to hold, because one string was "playObject", while another was
"PlayObject".
We also modify continuous-integration.yml, since macOS unit tests are
not automatically discovered, to include our unit test binary
test-toolEnums.
|
This depends on #3467 |
|
Please rebase onto |
|
Done. |
LittleHuba
approved these changes
Oct 21, 2021
idotobi
reviewed
Oct 21, 2021
idotobi
approved these changes
Oct 21, 2021
|
Should we merge this then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the following invariant:
for all enum values of ToolSize and ToolType.
This check is motivated by a bug discovered, where this invariant failed
to hold, because one string was "playObject", while another was
"PlayObject".
We also modify continuous-integration.yml, since macOS unit tests are
not automatically discovered, to include our unit test binary
test-toolEnums.