Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholders in "Default save name" #5123

Closed
MichelReims opened this issue Sep 5, 2023 · 2 comments
Closed

Placeholders in "Default save name" #5123

MichelReims opened this issue Sep 5, 2023 · 2 comments
Labels
bug Crash Dependency Issue The issue is within a dependency and cannot be solved by us. PR available There is currently an implementation in review that fixes this issue

Comments

@MichelReims
Copy link
MichelReims commented Sep 5, 2023 •
edited
Loading

Operating System

Windows

(Linux only) Distribution

No response

(Linux only) Desktop Environment

No response

(Linux Only) Display Server

None

Installation Method

xournalpp-1.2.1+dev-nightly.20230831-windows.exe

Xournal++ Version

xournalpp-1.2.1+dev-nightly.20230831-windows

libgtk Version

3.24.39

Bug Description

In Preferences->Load/Save->Default Save Name, the placeholders %c, %F, %X and %Z does not work (and %Z crashes Xournalpp)
I work in French but xournal does not take my chosen language when it replaces placehoders ( It writes in English)

Expected Behaviour

Possibility of using %c, %F, %X and %Z in "Default save name" and use the right language

Steps to Reproduce

Use %c, %F, %X and %Z in "Default save name"

Additional Context

No response
@MichelReims MichelReims added the bug label Sep 5, 2023
@Febbe Febbe added the Dependency Issue The issue is within a dependency and cannot be solved by us. label Sep 13, 2023
@Febbe
Copy link
Collaborator
Febbe commented Sep 13, 2023 •
edited
Loading

This is most likely not solvable for now. GCC on Windows does not support locales. Therefore, we are stuck with the C locale.

Edit: the crash might be an overflow bug. And that the other placeholders do not work is due to the fact, that it generates illegal characters.

Febbe added a commit to Febbe/xournalpp that referenced this issue Sep 13, 2023
@Febbe
Added user input validation for default filenames
37763e6 
 - fixes xournalpp#5123 partially
@Febbe Febbe mentioned this issue Sep 13, 2023
Merged
@Febbe Febbe added Crash PR available There is currently an implementation in review that fixes this issue labels Sep 13, 2023
@MichelReims
Copy link
Author

Thank you for reply

Febbe added a commit to Febbe/xournalpp that referenced this issue Oct 3, 2023
@Febbe
Added user input validation for default filenames
42b1ae1 
 - fixes xournalpp#5123 partially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Crash Dependency Issue The issue is within a dependency and cannot be solved by us. PR available There is currently an implementation in review that fixes this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Febbe @MichelReims