dll: add support for disabling directio. #626
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #615
After setting the fuse.directio flag in cgofuse lib, I think the only thing left is to pass this flag to IRP_CREATE.Rsp.Create.Opened.DisableCache. To achieve that, I expanded the OPEN interface to accept a DisableCache pointer in this PR.
Another approach I considered is changing the parameter type from
FSP_FSCTL_FILE_INFO *FileInfo
toFSP_FSCTL_OPEN_FILE_INFO *
, and then adding aDisableCache
field into theFSP_FSCTL_OPEN_FILE_INFO
struct.Both methods seem fine to me. Do you think there is a better solution, or is there something I might have overlooked?
Before submitting this PR please review this checklist. Ideally all checkmarks should be checked upon submitting. (Use an x inside square brackets like so: [x])