chore: standardise coding #1546
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cce834 to
48a70e7
Compare
missed a few over-zealous sed edits
Also fix a performance issue by using the CACHE_FILE as normal rather than fetching and parsing from github again to get the non-rc release version to filter the cache file. Also add a comment to suggest how to override to get release candidates too.
ac0edd5 to
38c93f2
Compare
38c93f2 to
02851a4
Compare
No activity for a couple of years and latest debb fails to install
Had to merge this fix in to allow CI to pass fixes wimpysworld#1507 replaces wimpysworld#1492 closes wimpysworld#1509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1507
replaces #1492
closes #1509
A lot of slightly-different implementations have arisen because of many valuable contributions re-using prior art at the same time as many other valuable contributions have
improved style, functionality, performance.
This is an attempt to standardise the majority of "similar" definitions. Besides conforming white-space styling to the model set out in the EXTREPO.md the main changes have been
echo "${URL}"| ... | tr -d vwith<<< "${URL/v/}"sedinvocations with similar variable substitutions$( )invocations .The CI test is failing to install all the changed packages. This has identified a couple of issues but some that fall over in CI install OK locally. Looks like either a long wade through breaking changes to get to a squashable PR, a hard look at the CI to try and fix some issues there and improve behaviour or parking and splitting this PR into a lot of individual changes for each definition (excluding the deprecations and ones where pending PRs (most of which have been aligned with this work) might apply.