Fix isEqual.js: avoid syntax error on IE11 #8094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<
2A94
/div>
Proposed changes
When I tried
element.isEqual()
on IE11, webdriver returned an error because IE11 does not support the arrow function syntax.I tried this code https://gist.github.com/FujiHaruka/e74fd83edb1a273c61ed8b82b94b798c on BrowserStack and got error logs like below.
I'm not sure whether WebdriverIO supports IE11 or not, but it would be nice if we can run WebdriverIO on IE11 with less efforts. So my humble suggestion is using a plain function instead of an arrow function in isEqual.js. I confirmed that my code above works fine with this change.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers