Fix #505: Remove undefined behavior in modname_from_fn #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #505 - undefined behavior in the
modname_from_fn
function.Problem
The function had two UB issues:
strrchr(fn, c) + 1
whenstrrchr
returns NULLfn < off
whenoff
is NULLThis caused crashes in debug builds as reported by @InBetweenNames.
Solution
Changed the logic to safely handle NULL returns from
strrchr()
:Before: