Fix #452 — Resolve print error in WASI execution by correcting function declarations and compilation #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yasararf
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
The changes in this pull request correctly address issue #452. Function declarations were properly added, buffer handling was fixed, and the WASI compilation command was corrected. These adjustments resolve the runtime print issue and ensure the program executes successfully under wasm3. The code changes are clear, maintainable, and follow good practices. I recommend approving this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #452, where the program produced no output when executed in wasm3. The following changes have been made to fix the issue:
Added missing function declarations in main.c to ensure proper compilation and linking.
Fixed zero-length buffer issue in fd_advise to prevent runtime errors.
Corrected WASI compilation target (unknown-wasi) to ensure successful build.
Improved error handling and ensured proper file descriptor management.
Verified execution with wasm3 --dir=./Data open.wasm, producing the expected console output.
These improvements make the program compile and run successfully in WASI environments while producing the expected debug output.