Added type check to index var for br_table #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a bunch of the tests to fail, though.
I went through and messed with the JSON to just simply convert any function that relies on passing any non-i32 value to br_table, from expecting values, to expecting the error. I'd like to speak with someone before making another pr on the testsuite archive repo that the python script pulls from.
However, I'm not very comfortable with the codebase, and I'm not able to dedicate an extreme amount of time to understand it further. So I'd like someone more familiar with the codebase to look and see if my error checking is done in the right place and on the right thing, and I'd also appreciate some advice and helping checking/fixing the json testing
edit: This should fix #519