Implement faster* BE ABI #456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this borrows the idea from Wasm2C, which stores the whole linear memory in reverse order? |
|
yeah, that was the idea... maybe it'd be too much of a maintenance burden tho, sorry. >.< |
|
The idea is great. However, to merge it, we must make it compatible (syntax wise) with the existing imported C functions syntax. I'm not sure if this is possible... |
|
Oh, looks like it doesn't need any API changes on the Little Endian systems. |
|
nah, that's pretty much all there is to it, but that's where we ran into #457 and gave up, the changes seemed really big and unapproachable >.< |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to make wasm3 faster for compute-heavy workloads on big-endian platforms. We can do this by changing the ABI.
Notes: wasi implementation has not been updated for this ABI (wasi tests fail completely), CI has not been updated to run any tests for this ABI but spec tests pass locally.