Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use correct variable name #233

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Fix to use correct variable name #233

merged 1 commit into from
Sep 11, 2020

Conversation

naglis
Copy link
Contributor
@naglis naglis commented Sep 10, 2020

From the context (normalized should be a map here), I think it should be normalized, not item.


Preview | Diff

@iherman
Copy link
Member
iherman commented Sep 11, 2020

Marked as non substantive for IPR from ash-nazg.

Copy link
Member
@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is indeed a bug there but, when it comes to a bug in the processing algorithm, I'd prefer the approval of the other editor, too. @mattgarrish?

@mattgarrish
Copy link
Member

Looks like a copy-paste error. item is only defined for iterating the list, so for the map case, yes, it should just be normalized["type"].

@mattgarrish mattgarrish merged commit 9a17073 into w3c:master Sep 11, 2020
@naglis naglis mentioned this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants