Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-conditional-3] Remove procedure to set readonly CSSMediaRule.con… #8796

Merged
merged 1 commit into from
May 5, 2023
Merged

[css-conditional-3] Remove procedure to set readonly CSSMediaRule.con… #8796

merged 1 commit into from
May 5, 2023

Conversation

cdoublev
Copy link
Collaborator
@cdoublev cdoublev commented May 5, 2023

6c659d6 changed CSSConditionalRule.conditionText to readonly, as resolved in #6819.

This PR removes the procedure to set CSSMediaRule.conditionText, which I think is an oversight:

I suppose the fact that @media does have the .media mutable means it's okay for the .conditionText to be a readonly version that covers everyone

@tabatkins tabatkins merged commit 1141d2b into w3c:main May 5, 2023
@cdoublev cdoublev deleted the issue-6819 branch May 8, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdoublev @tabatkins