Move extension processing to after signature verification, and modernize it #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacknewman
reviewed
Oct 1, 2024
sbweeden
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Looks good to me - I think this can be merged at next WG call @nicksteele
MasterKale
approved these changes
Oct 9, 2024
|
2024-10-30 WG call: ok to merge after fixing conflicts |
github-actions bot
added a commit
that referenced
this pull request
Nov 13, 2024
SHA: 92e1015 Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1711. Fixes a small part of #1979.
Preview | Diff