@berlin-ab, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 61880f3 must be signed by aberlin@vmware.com

After installing the CRD, I couldn't figure out how to make the CRDs active. I eventually pulled up the codebase and took a look around. What do you think about allowing multiple datasources? If this is meant to be used by many teams, each team might have their own preference (configmap vs crds for example) and we should support both at the same time.

Even though the CRD gets installed by the operator once datasource: crd is set in the values.yaml. I think that it's an odd experience to perform a helm install and the CRD is automatically installed.

/lgtm

Could we add some helm value to install or not the crd like .Values.InstallCrd: enabled?

@javiercri That makes sense. In that case I think the default should be .values.installCrd==true

Sure. That is a good option

@berlin-ab, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 3485024 must be signed by aberlin@vmware.com

@javiercri I introduced the helm chart flag installCrd with a default of enabled. I tested these changes via helm template locally because I didn't see a standard way of testing these properties.

We need to figure out what to do about the kubectl/crd.yaml file