Remove DaisyUI #26
Merged
Remove DaisyUI #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes DaisyUI and updates the UI package by replacing ag‑grid‑solid with solid‑ag‑grid, refactoring CSS into a custom utility‑based system, and updating various components for improved styling and functionality.
- Dependency updates and removal of DaisyUI
- CSS refactoring with new utility classes in multiple components
- Component improvements including Filters, Download, and layout updates
Reviewed Changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/pages/normalize/index.tsx | Updated button, card, and spinner styling with new utility classes |
| ui/src/pages/layout.tsx | Removed dark mode toggle and updated header styling |
| ui/src/pages/analyze/useViewModel.tsx | Replaced ag‑grid‑solid import and removed unused state variable |
| ui/src/pages/analyze/index.tsx | Updated grid options and replaced ag‑grid‑solid import |
| ui/src/pages/analyze/gridService.ts | Set sortable flag for specific columns |
| ui/src/components/timeJumps/index.tsx | Updated layout and tooltip structure |
| ui/src/components/jsonCellRenderer/jsonFormatter.ts | Updated JSON formatter color variables |
| ui/src/components/groupedMsgGrid/index.tsx | Updated card and grid styling |
| ui/src/components/fullDataCellRenderer/index.tsx | Updated context button styling |
| ui/src/components/filters/useViewModel.tsx | Renamed filter name signals and updated filter saving logic |
| ui/src/components/filters/useViewModel.test.tsx | Updated tests for handling filter names |
| ui/src/components/filters/index.tsx | Updated Filters UI with refined layout and utility classes |
| ui/src/components/download/index.tsx | Updated Download button styling |
Files not reviewed (4)
- ui/package.json: Language not supported
- ui/pnpm-lock.yaml: Language not supported
- ui/src/app.css: Language not supported
- ui/src/index.css: Language not supported
Comments suppressed due to low confidence (2)
ui/src/pages/layout.tsx:44
- The dark mode toggle state and the associated effect have been removed from the Layout component. Please ensure that theme management is now handled elsewhere or that this removal is intentional.
const [isDarkMode, setIsDarkMode] = createSignal( ... )
ui/src/components/filters/useViewModel.tsx:71
- [nitpick] The renaming from 'savedFiltersNames' to 'storageFilterNames' (and the corresponding use of 'activeFilterName') may be confusing when interfaced externally as 'savedFilterName'. Consider clarifying the naming to clearly differentiate between the active filter name and the list of saved filter names.
function storageFilterNames(): string[] {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
uipackage, focusing on dependency updates, CSS refactoring, and component improvements. The changes include replacingag-grid-solidwithsolid-ag-grid, removingdaisyui, introducing a custom utility-based CSS system, and improving the styling and functionality of components likeFilters.Dependency Updates:
ag-grid-solidwithsolid-ag-grid(version^0.0.230) inui/package.jsonand updated corresponding references inui/pnpm-lock.yaml. [1] [2] [3]daisyuifromui/package.jsonand its references fromui/pnpm-lock.yaml. [1] [2] [3]CSS Refactoring:
ui/src/app.css, adding reusable utility classes for buttons, inputs, cards, badges, and tooltips.Component Updates:
Filterscomponent inui/src/components/filters/index.tsxto use new utility classes for better styling. Adjusted the layout and added asavedFilterNamesprop for enhanced functionality. [1] [2] [3]ag-grid-solidimports withsolid-ag-gridinFiltersand updated related logic.Minor Changes:
Downloadbutton inui/src/components/download/index.tsxto use the new utility classes for styling.