DX-1780: Add HEXPIRE #1367
Merged
DX-1780: Add HEXPIRE #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like changes are also needed in the following files: |
|
Kudos for the detailed test cases |
yunusemreozdemir
previously approved these changes
Apr 2, 2025
because we used overloads, using ReturnType on createScript didn't work as expected. Changed to a generic
yunusemreozdemir
previously approved these changes
Apr 3, 2025
a63eb75 to
6a63941
Compare
|
tests started to fail b/c of another change in redis server about setting past expiration times. Fixed that too. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HEXPIRE command: