rename E_MEMORY to E_MEMORY_ALLOC #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the errors for the Windows builds it seems to all be errors about the docs build. Is that even intended to build on Windows? Or is something else breaking the build from this PR? |
nrabinowitz
approved these changes
Jul 5, 2022
|
Needs a rebase, but LGTM otherwise. |
isaacbrodsky
approved these changes
Jul 6, 2022
dfellis
approved these changes
Jul 6, 2022
isaacbrodsky
pushed a commit
to isaacbrodsky/h3
that referenced
this pull request
Jul 22, 2022
isaacbrodsky
added a commit
that referenced
this pull request
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E_MEMORY_ALLOCis a slightly more descriptive name.