build: Omit SELINUX_PROGS to avoid build failure without SELinux #8955
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
sylvestre
reviewed
Oct 20, 2025
|
GNU testsuite comparison: |
|
sorry but i still don't understand why you have to do that ? |
|
Because this project is impossible to build on Linux without |
|
Skipping SELINUX_PROGS is same behavior with |
10000
oech3
changed the title
Omit SELINUX_PROGS on non SELinux env
build: Omit SELINUX_PROGS to avoid build failure without SELinux
Oct 20, 2025
|
Sorry but I still don't get why you need to touch the gnu testsuite. I want to run runcon against them |
oech3
commented
Oct 20, 2025
| cd - | ||
|
|
||
| # Add missing SELINUX_PROGS for tests | ||
| cargo build --profile="${UU_MAKE_PROFILE}" -p uu_runcon -p uu_chcon |
There was a problem hiding this comment.
@sylvestre Switched to force-adding method instead of skipping tests.
There was a problem hiding this comment.
Still no with this form?
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7996 (build failure on system missing libselinux).
Separated from #8937 because of unknown test failure for Android.