hashsum: don't fail on dirs #8930
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8912.
Instead of failing on directories, outputs the OS
Is a directory
error message and continues with the remaining files to match GNUmd5sum
behaviour. Note that the error message slightly differs from the GNU counterpart as it includes(os error 21)
. I wasn't able to come up with a clean solution to not include the error code and wasn't sure how critical this discrepancy is considered.Additionally, I considered looking at the metadata of the path to see if it is a directory instead of having
digest_reader
error out. However, that implementation appeared to require significantly more edge case handling.