Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eselect-{kernel,profile}: add page #13937

Merged
merged 2 commits into from
Oct 3, 2024
Merged

eselect-{kernel,profile}: add page #13937

merged 2 commits into from
Oct 3, 2024
+36 −0

Conversation

acuteenvy
Copy link
Member
  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 2, 2024
spageektti
spageektti reviewed Oct 2, 2024
View reviewed changes
Copy link
Member
@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main page for eselect is missing the "some subcommands such as..." line.

@acuteenvy
Copy link
Member Author

The main page for eselect is missing the "some subcommands such as..." line.

Yeah, but instead there is an example that shows how to read a page for a subcommand. Isn't that enough?

@spageektti spageektti merged commit eca27b3 into tldr-pages:main Oct 3, 2024
4 checks passed
@acuteenvy acuteenvy deleted the eselect-kern-profile branch October 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@spageektti spageektti spageektti approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acuteenvy @sebastiaanspeck @spageektti