Updating tiny keys, adding shortcut tests #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@timc1 Any thoughts on the above changes? |
|
+1 to adding tinykeys as a package instead of adding the source code edit, I did a patch on my project that simply used the tinyKeys package and it fixed it for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374, and adds some unit tests around shortcuts. Admittedly, the shortcut cases are pretty sparse. I'd be happy to add any new cases or update if it's apropriate.
Alternatively, is there a reason we don't just import tinyKeys as a dependency? I'd be happy to update the PR to do this as well, rather than copy the source for tinyKeys into the repo