Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limiting issue on Holders View #816

Open
pmjanus opened this issue Aug 5, 2024 · 2 comments · Fixed by #850
Open

Rate limiting issue on Holders View #816

pmjanus opened this issue Aug 5, 2024 · 2 comments · Fixed by #850
Assignees
@Viterbo

Comments

@pmjanus
Copy link
Contributor
pmjanus commented Aug 5, 2024 •
edited
Loading

Describe the bug

Rate limiting issue when making too many requests to the TelosScan API for retrieving token holders.
https://www.teloscan.io/address/0xa9991E4daA44922D00a78B6D986cDf628d46C4DD?tab=holders

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the holders page
  2. Load a large number of token holders by paginating or requesting a large result set

Expected behavior

The application should be able to retrieve and display token holder information from the TelesScan API without encountering rate limiting errors (429 status code).
@Viterbo Viterbo self-assigned this Aug 5, 2024
@Viterbo
Copy link
Collaborator
Viterbo commented Aug 19, 2024 •
edited
Loading

#830 partially addresses this issue since it creates a large cache of address names for the same purposes.

Also, this issue depends very much on https://github.com/telosnetwork/teloscan-indexer/issues/268

@Viterbo Viterbo added the 🚫 Blocked Work cannot be done until blocker is resolved label Aug 19, 2024
@Viterbo Viterbo removed the 🚫 Blocked Work cannot be done until blocker is resolved label Sep 5, 2024
This was referenced Sep 6, 2024
Closed
Merged
@Viterbo Viterbo linked a pull request Sep 6, 2024 that will close this issue
#816 | change the strategy to only fetch contracts from cache #850
Merged
@Viterbo
Copy link
Collaborator
Viterbo commented Sep 6, 2024

This issue will be solved with this PR changing the strategy to fetch the contract's metadata from the local cache and delegating the API the responsibility of populating that cache.

pmjanus added a commit that referenced this issue Oct 28, 2024
@pmjanus
Merge pull request #850 from telosnetwork/816-rate-limiting-issue-on-…
a7e267f 
…holders-view-2

#816 | change the strategy to only fetch contracts from cache
@pmjanus pmjanus mentioned this issue Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#816 | change the strategy to only fetch contracts from cache telosnetwork/teloscan
2 participants
@Viterbo @pmjanus