-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose fit #285
base: master
Are you sure you want to change the base?
Verbose fit #285
Conversation
I also played around with caching the objective evaluations by having |
That output looks great! Perfect information for slow fits. The "last" vs "avg" iter time will be particularly useful for diagnosing peculiarities. For example, I've recently been trying to fit large systems of ODEs that become "stiff" only for certain parameter values, resulting in massive slowdown. This would help catch that sort of thing. |
I like this a lot too, just needs documentation and testing as far as I'm concerned. Other than that it's a good step in this direction, and it also sets a good example for how people could define their own callback for their specific needs. |
This should address your code issues, and adds tests. |
I'm getting unrelated test failures: HadamardProduct is not defined. Do you have any idea what could be causing them? |
Here's an initial mock-up of a
FitStatus
object that can be used to track convergence. I still need to add tests (and make sure the docs build).@JohnGoertz would this suit your needs?
Closes #280