Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridgy Publish to Flickr: detect hashtags and set Flickr tags #604

Closed
tantek opened this issue Jan 17, 2016 · 13 comments
Closed

Bridgy Publish to Flickr: detect hashtags and set Flickr tags #604

tantek opened this issue Jan 17, 2016 · 13 comments
Labels

Comments

@tantek
Copy link
Contributor
tantek commented Jan 17, 2016

Bridgy Publish supports publishing photos (including user tags) to Flickr, what's missing is normal / plain Flickr tags.

There are two ways an indieweb post can tag a post that Bridgy Publish should consider picking up:

  1. # hashtags. Hashtags in the (p-)name, (p-)summary, (p-)content property values could (should) be parsed out as intended as tagging the photo/video.
  2. (p-)category markup. Since Bridgy Publish is already parsing for (u-)category properties, and this parsing should be generic to any kind of (*-)category property, if/when a 'category' property is not a URL (thus not person-tag), then it should be treated as a plain text tag.
@snarfed
Copy link
Owner
snarfed commented Jan 17, 2016

thanks for filing!

publish actually already propagates p-category mf2 tags to Flickr tags. @kylewm added that pretty recently. this is a good nudge to add it to the docs.

as for hashtags in plain text, I'm not sure. i get that #hashtag syntax is pretty universal now, and i get that it's necessary in silos that don't allow explicit tags, but publish users generally own their markup and get to author explicit mf2 tags with p-category.

given that, I'm a bit reluctant to promote text only #hashtags to explicit silo tags... but i dunno. thoughts?

@kylewm
Copy link
Contributor
kylewm commented Jan 17, 2016

I notice that Known autolinks hashtags so "category": ["#indieweb"]. If we stripped the octothorpe for silos that don't use it, that might be a happy medium? Then sites like tantek's that want interpret them as tags could make it explicit by wrapping them with a <span class="p-category">

@snarfed
Copy link
Owner
snarfed commented Jan 17, 2016

(daaamn it's a sunday morning and @kylewm got me all https://www.google.com/search?q=define%3Aoctothrope )

@snarfed
Copy link
Owner
snarfed commented Jan 17, 2016

stripping octothpus sgtm!

@tantek
Copy link
Contributor Author
tantek commented Jan 17, 2016

@snarfed I'm sympathetic to not overdoing the smarts re: "reluctant to promote text only #hashtags to explicit silo tags".

This might be another example of not over-interpreting text (e.g. whitespace) into markup.

Even if you do end up rejecting this suggestion (to autopromote plain text hashtags to categories/tags), I wanted to capture it (and subsequent analysis) because I expect it will come up again.

@tantek tantek changed the title Bridgy Publish to Flickr: detect hashtags and p-category and set Flickr tags Bridgy Publish to Flickr: detect hashtags and set Flickr tags Jan 17, 2016
@tantek
Copy link
Contributor Author
tantek commented Jan 17, 2016

Narrowed the scope since p-category tags are already supported apparently. Just need to update the docs re: p-category. Update: pull request for docs update: #605

@singpolyma
Copy link
Contributor

This publish brid.gy did https://www.flickr.com/photos/singpolyma/24001981743/ seems to have the hashtag autolinked (maybe flickr did that from the plain text?) but then the tag itself is not on the post? A bit confusing UX on the flickr side, not sure if my tag ended up on the post or not. My tag is marked up using rel=tag in the hentry, so it seems like brid.gy should be able to pick it up?

@snarfed
Copy link
Owner
snarfed commented Jan 26, 2016

discussing in IRC now.

@kylewm
Copy link
Contributor
kylewm commented Jan 26, 2016

@singpolyma http://sngpl.ma/t4fS0 is returning 404, can you point me to the original that was POSSEd? My guess is mf2py isn't doing backcompat for rel=tag

@singpolyma
Copy link
Contributor

@kylewm oh, right, my short domain is still down (grumble,grumble morocco) -- full URL https://singpolyma.net/actionstream/boring-cabinets/

@kylewm
Copy link
Contributor
kylewm commented Jan 26, 2016

great! so I think if you just add class="p-category" on that tag, it'll work just fine.

@kylewm
Copy link
Contributor
kylewm commented Jan 26, 2016

Should be backward-compatible with rel=tag now, so you don't need to change your markup.

@snarfed
Copy link
Owner
snarfed commented Nov 26, 2016

tentatively closing due to discussion above: p-category tags are supported and documented.

@snarfed snarfed closed this as completed Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants