Fix React warning with useGeometry
deps array
#1687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a breaking change in the signature of the
useGeometry
hook to fix #1684The problem came from passing
false
orundefined
as the value of theparams
parameter in order to skip updating the geometry (e.g. when the R3F object is hidden). I change the signature of the hook to decouple this feature from theparams
parameter: the hook now accepts aconfig
object as fourth argument (which also makes theisInteractive
boolean more explicit).