Upgrade R3F #1494
Merged
Upgrade R3F #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Sep 15, 2023
| */ | ||
| .canvasArea, | ||
| .r3fRoot { | ||
| pointer-events: none !important; |
There was a problem hiding this comment.
R3F now sets pointer-events: auto on r3fRoot when it registers events to it (i.e. when no custom eventSource element is provided), so I need to override that back to none so it doesn't intercept events before they reach other interactive elements.
For now, I'm basically making sure everything still works as it did before: R3F events bubble up to r3fRoot after being fired on the canvas element; they are not directly fired on r3fRoot. I have ideas on how to make the whole thing more straight-forward and resilient by decoupling stacking concerns from interaction concerns.
loichuder
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 8.0.14 to 8.14.1 (version 8.1.0 is on page 7).
.parentElementto get tor3fRootand a change to ther3fRoot > canvasCSS selector. R3F still registers events onr3fRoot.Lineelement to not conflict with SVGlinein JSXThreeElementsto access the prop types of Three objects - e.g.ThreeElements['mesh']=>MeshProps— it could come in handy:<T extends 'mesh' | 'points'>(props: ThreeElements[T]) => voidgl.domElement.parentNode(i.e.r3fRoot). This is going to enable further refactoring and new features like the picking API.Canvascan now access contexts provided outside of R3F, like the toolbar configs (not that we want to do that). I think this opens the door to refactoring opportunities, notably in Daiquiri.OffscreenCanvas! Maybe a way forward for #95...